Closed
Bug 1260612
Opened 9 years ago
Closed 9 years ago
Run away Speech Synthesizer can speak for ever
Categories
(Core :: Web Speech, defect)
Core
Web Speech
Tracking
()
VERIFIED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | verified |
People
(Reporter: BijuMailList, Assigned: eeejay)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
This a kind of "eviltraps" (Bug 432687)
A site can keep talking/speaking for ever (long long time).
And there will be now way for user to stop it.
Follow the instructions in speak_for_ever.html
Comment 1•9 years ago
|
||
(In reply to Biju from comment #0)
> Created attachment 8736122 [details]
> speak_for_ever.html
>
> This a kind of "eviltraps" (Bug 432687)
>
> A site can keep talking/speaking for ever (long long time).
> And there will be now way for user to stop it.
>
> Follow the instructions in speak_for_ever.html
What Firefox version and platform do you test?
Flags: needinfo?(BijuMailList)
Comment 2•9 years ago
|
||
I can reproduce on Windows 8, at least. Eitan?
Flags: needinfo?(BijuMailList) → needinfo?(eitan)
Assignee | ||
Comment 3•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/43309/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43309/
Attachment #8736464 -
Flags: review?(bugs)
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(eitan)
Assignee | ||
Comment 4•9 years ago
|
||
Yup, I can reproduce and can fix.
Comment 5•9 years ago
|
||
Comment on attachment 8736464 [details]
MozReview Request: Bug 1260612 - Cancel speech entirely (including queue) when window is destroyed. r?smaug
https://reviewboard.mozilla.org/r/43309/#review39925
Attachment #8736464 -
Flags: review?(bugs) → review+
Is this fixed on trunk? if not, when can we expect. Thanks for all great work.
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to Biju from comment #6)
> Is this fixed on trunk? if not, when can we expect. Thanks for all great
> work.
I believe it is fixed in nighty, just verified. Do you still see this issue?
Comment 8•9 years ago
|
||
The fix in this patch seems to have landed as part of bug 1254378, and should be in Nightlies later than April 2nd.
Biju, can you confirm it's fixed for you?
Depends on: 1254378
Flags: needinfo?(BijuMailList)
Test Result : PASS
Tested on 48.0a1 (2016-04-05) and I no longer see this issue.
BTW, I see this issue resolved since two days, but was confused after seeing the status of this bug is still showing NEW.
Another question.
I see narrate button/icon only on pages with "read mode".
And all web pages dont get to switch to read mode option.
I wish there is narrate icon visible for every page, as well as narrate context menu item. So that I can select some text content on the page, and then click narrate button, or use right click context menu to read it.
Do we have a bug asking for selection narrate icon/menu ?
Comment 10•9 years ago
|
||
Thanks for confirming this has been addressed!
(In reply to Biju from comment #9)
> I see narrate button/icon only on pages with "read mode".
> And all web pages dont get to switch to read mode option.
> I wish there is narrate icon visible for every page, as well as narrate
> context menu item. So that I can select some text content on the page, and
> then click narrate button, or use right click context menu to read it.
>
> Do we have a bug asking for selection narrate icon/menu ?
Eitan might know.
Assignee: nobody → eitan
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(BijuMailList) → needinfo?(eitan)
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Assignee | ||
Comment 11•9 years ago
|
||
(In reply to Biju from comment #9)
> Test Result : PASS
> Tested on 48.0a1 (2016-04-05) and I no longer see this issue.
>
> BTW, I see this issue resolved since two days, but was confused after seeing
> the status of this bug is still showing NEW.
>
> Another question.
> I see narrate button/icon only on pages with "read mode".
> And all web pages dont get to switch to read mode option.
> I wish there is narrate icon visible for every page, as well as narrate
> context menu item. So that I can select some text content on the page, and
> then click narrate button, or use right click context menu to read it.
>
> Do we have a bug asking for selection narrate icon/menu ?
We don't have any specific plan for that yet, although that may be a good future addition. I decided to go with reader mode first because the content is already sanitized and decluttered from items and text you don't want spoken.
Flags: needinfo?(eitan)
Reporter | ||
Comment 12•9 years ago
|
||
(In reply to Eitan Isaacson [:eeejay] from bug comment #11)
Created Bug 1262738
Comment 13•8 years ago
|
||
Verified fixed on Windows 7 64bit, Ubuntu 14.04 64bit and Mac OSX 10.10.5 using Firefox 48 Beta 2, buildID: 20160620091522 (with "media.webspeech.synth.enabled" set to true).
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•