Closed
Bug 1260823
Opened 9 years ago
Closed 9 years ago
MozillaBuild 2.2.0 won't start when MOZ_NO_RESET_PATH is set if existing PATH contains spaces
Categories
(Firefox Build System :: MozillaBuild, task)
Firefox Build System
MozillaBuild
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bugzilla, Assigned: myk)
References
Details
Attachments
(1 file)
(deleted),
patch
|
RyanVM
:
review+
|
Details | Diff | Splinter Review |
In start-shell.bat, the line:
SET PATH=%PATH%;!LLVMDIR!\bin
fails if PATH contains any spaces. Adding quotes like so:
SET PATH="%PATH%;!LLVMDIR!\bin"
appears to have fixed it.
Reporter | ||
Updated•9 years ago
|
Flags: needinfo?(ryanvm)
Comment 1•9 years ago
|
||
This might be what I was seeing. I got an error saying something like 'Usage of "\PHP\" is incorrect'. I downgraded to MozillaBuild 2.1.0 and it appears to have fixed the problem.
Comment 2•9 years ago
|
||
Seeing this on my home computer too.
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8738221 -
Flags: review?(gps)
Comment 5•9 years ago
|
||
Comment on attachment 8738221 [details] [diff] [review]
quote value containing delayfully-expanded variable
Review of attachment 8738221 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks.
Attachment #8738221 -
Flags: review?(gps) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Assignee: nobody → myk
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 7•9 years ago
|
||
I'll try to spin a new release soon to pick up this fix.
Flags: needinfo?(ryanvm)
Comment 8•8 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #7)
> I'll try to spin a new release soon to pick up this fix.
Hi Ryan! Any update on this?
Flags: needinfo?(ryanvm)
Comment 9•8 years ago
|
||
We're going in a different direction. Greg has an intern who's got msys2 nearly completely functional for building Firefox, which will entirely obsolete MozillaBuild. As a result, the plan is to not ship any new releases unless a critical issue appears.
Flags: needinfo?(ryanvm)
Comment 10•8 years ago
|
||
Ok, good to hear! For what it's worth, I'm stuck on MozillaBuild 2.1.0 on all my machines due to this bug so hopefully msys2 comes soon!
Comment 11•8 years ago
|
||
Sorry for the annoyance. You can always make the start-shell.bat tweak from the attached patch locally post-install, though.
Comment 12•8 years ago
|
||
Oh I didn't realize it was a simple as editing the batch file. That's great. Thanks!
Updated•2 years ago
|
Product: mozilla.org → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•