Closed
Bug 1261359
Opened 9 years ago
Closed 9 years ago
Don't set HOST_{C,CXX,LD}FLAGS from {C,CXX,LD}FLAGS at all
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: glandium, Unassigned)
References
Details
Attachments
(1 file)
No description provided.
Reporter | ||
Comment 1•9 years ago
|
||
In bug 1260996, we straightened things up for the host flags on cross
compile builds, where the situation was that they were effectively empty
by default, and that hasn't changed.
While working on bug 1260996, it has become clear that there is no much
point in setting the host flags from the target flags on non cross
compile builds, especially when the target flags come from the environment.
That creates a discrepancy with cross compilation builds for no real
reason, and there are effectively too few host things to build that it
would matter anyways. The flags that do matter are the ones for C++11,
C99, and optimisations, and they all are set independently of what is
being removed here.
Review commit: https://reviewboard.mozilla.org/r/43803/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43803/
Attachment #8737204 -
Flags: review?(nalexander)
Comment 2•9 years ago
|
||
Comment on attachment 8737204 [details]
MozReview Request: Bug 1261359 - Don't set HOST_{C,CXX,LD}FLAGS from {C,CXX,LD}FLAGS at all. r?nalexander
https://reviewboard.mozilla.org/r/43803/#review40387
Attachment #8737204 -
Flags: review?(nalexander) → review+
Comment 4•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•