Closed Bug 1261782 Opened 9 years ago Closed 8 years ago

Bookmark star greyed out once url edited

Categories

(Firefox :: Bookmarks & History, defect)

45 Branch
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 943888

People

(Reporter: limkokhole, Unassigned)

Details

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0 Build ID: 20160315153207 Steps to reproduce: 1. Visits https://www.google.com/?gws_rd=ssls 2. Insert/remove/edit url in url bar. Actual results: 1. Bookmark star greyed out. 2. Even you edit back the url to original url, bookmark star will not recover from grey. Expected results: Bookmark star shouldn't greyed out: [1] As "Bookmark This page" or Ctrl+D still able to bookmark. [2] Also, if edit by javascript window.location.hash = 'something'; to change url will not greyed out bookmark star, then why edit manually in URL bar will greyed out bookmark star ? But, if greyed out is expected by desgin, then the bookmark should change back non-grey after url edited to original. Also, "Bookmark This page" or Ctrl+D shouldn't allow. window.location.hash should take effect too. The behavior should be consistent for all cases if greyed out is either expected or not.
Component: Untriaged → Bookmarks & History
OS: Unspecified → Windows 8
OS: Windows 8 → Unspecified
this is by design cause the star was once bound to the urlbar, and we had to make clear the star didn't reflect the input field content when it was not the last visited page. Pressing ESC (twice in some cases) should bring back the input field to the last valid status and the star will be enabled again. It may change in future, indeed we are evaluating to remove the disabled status, but still the star will reflect status of what's visible in the tab content, won't have anything to do with the urlbar. This a dupe of the bug where we could remove the disabling, but I can't find it atm.
Whiteboard: [DUPEME]
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Whiteboard: [DUPEME]
You need to log in before you can comment on or make changes to this bug.