Closed Bug 1262178 Opened 9 years ago Closed 4 years ago

Streamline reading-list migrations

Categories

(Firefox for Android Graveyard :: Data Providers, defect)

defect
Not set
normal

Tracking

(firefox48 affected)

RESOLVED INCOMPLETE
Tracking Status
firefox48 --- affected

People

(Reporter: ahunt, Unassigned)

Details

In BrowserDatabaseHelper, we have multiple stages of reading-list migration: 1) 17->18: move reading list items from a (hidden?) bookmarks folder into the reading-list table 2) 21->22: add content-status column to the reading-list table 3) 22->23: more schema changes (different data in read/resolved-title/resolved-url columns) 4) 30->31: move reading list items back into bookmarks (normal bookmarks) Because of the 17->18 migration we need to keep createReadingListTable in BrowserDatabaseHelper, we could remove this if we had a direct 17->31 migration for reading-list data.
Doing this would require a lot of care to not break any of the upgrade permutations, and we'd want good test coverage to ensure we don't break anything. The 30->31 migration is being introduced in Bug 1234315. Note that any migration from <= 17 is broken due to Bug 1261907. (That bug serves as a good example of how easily upgrades can be broken, which make me somewhat hesitant about doing any streamlining of existing migrations.)
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.