Closed
Bug 1262273
Opened 9 years ago
Closed 9 years ago
Keep appcompat-v7 from getting Proguarded out
Categories
(Firefox Build System :: Android Studio and Gradle Integration, defect)
Firefox Build System
Android Studio and Gradle Integration
Tracking
(firefox48 fixed)
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
Details
Attachments
(4 files)
I am seeing https://code.google.com/p/android/issues/detail?id=187611 and http://stackoverflow.com/q/32813894 when building with Gradle in automation.
Why these aren't defined in appcompat-v7.aar/proguard.txt is beyond me, but they aren't, so we'll have to work around it.
Assignee | ||
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/44407/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44407/
Attachment #8738271 -
Flags: review?(michael.l.comella)
Assignee | ||
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Assignee | ||
Comment 4•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/44679/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44679/
Attachment #8738720 -
Flags: review?(michael.l.comella)
Attachment #8738721 -
Flags: review?(michael.l.comella)
Attachment #8738722 -
Flags: review?(michael.l.comella)
Assignee | ||
Comment 5•9 years ago
|
||
These are mostly used in TestGeckoProfile.
Review commit: https://reviewboard.mozilla.org/r/44681/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44681/
Assignee | ||
Comment 6•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/44683/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/44683/
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8738271 [details]
MozReview Request: Bug 1262273 - Keep appcompat-v7 from getting Proguarded out. r?mcomella
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/44407/diff/1-2/
Comment 10•9 years ago
|
||
Comment on attachment 8738271 [details]
MozReview Request: Bug 1262273 - Keep appcompat-v7 from getting Proguarded out. r?mcomella
https://reviewboard.mozilla.org/r/44407/#review41427
Attachment #8738271 -
Flags: review?(michael.l.comella) → review+
Comment 11•9 years ago
|
||
https://reviewboard.mozilla.org/r/44407/#review41429
fwiw, as of a month-ish ago, it seems this may have been fixed (though someone else questioned that):
https://code.google.com/p/android/issues/detail?id=78293#c10
It might be good to link that ticket though.
Comment 12•9 years ago
|
||
Comment on attachment 8738720 [details]
MozReview Request: Bug 1262273 - Keep View accessors from getting Proguarded out. r?mcomella
https://reviewboard.mozilla.org/r/44679/#review41433
Attachment #8738720 -
Flags: review?(michael.l.comella) → review+
Comment 13•9 years ago
|
||
Comment on attachment 8738721 [details]
MozReview Request: Bug 1262273 - Keep more GeckoProfile methods from getting Proguarded out. r?mcomella
https://reviewboard.mozilla.org/r/44681/#review41435
Attachment #8738721 -
Flags: review?(michael.l.comella) → review+
Comment 14•9 years ago
|
||
Comment on attachment 8738722 [details]
MozReview Request: Bug 1262273 - Keep support Fragment accessors from getting Proguarded out. r?mcomella
https://reviewboard.mozilla.org/r/44683/#review41437
Attachment #8738722 -
Flags: review?(michael.l.comella) → review+
Assignee | ||
Comment 15•9 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #11)
> https://reviewboard.mozilla.org/r/44407/#review41429
>
> fwiw, as of a month-ish ago, it seems this may have been fixed (though
> someone else questioned that):
>
> https://code.google.com/p/android/issues/detail?id=78293#c10
>
> It might be good to link that ticket though.
This is Google's "we close regardless of whether the bug is addressed" policy. The bug is definitely not fixed, and the policy is stupid.
Assignee | ||
Comment 16•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/99af9f32f1ca84ed3a7bb4345d5333ae40ce65b6
Bug 1262273 - Keep appcompat-v7 from getting Proguarded out. r=mcomella
https://hg.mozilla.org/integration/fx-team/rev/28c2a5b261c112c4c08f3e3ce53d8facbe51a44a
Bug 1262273 - Keep View accessors from getting Proguarded out. r=mcomella
https://hg.mozilla.org/integration/fx-team/rev/f60c206eb2841ef605421eb08b9380e940460972
Bug 1262273 - Keep more GeckoProfile methods from getting Proguarded out. r=mcomella
https://hg.mozilla.org/integration/fx-team/rev/165addeb1e58bf6791cc60c4c28f71a1558059a4
Bug 1262273 - Keep support Fragment accessors from getting Proguarded out. r=mcomella
Comment 17•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/99af9f32f1ca
https://hg.mozilla.org/mozilla-central/rev/28c2a5b261c1
https://hg.mozilla.org/mozilla-central/rev/f60c206eb284
https://hg.mozilla.org/mozilla-central/rev/165addeb1e58
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•5 years ago
|
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 48 → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•