Control needs an app launcher dialog just like mfcEmbed, so it can launch 3rd party helper apps, save to file etc. http://lxr.mozilla.org/seamonkey/source/embedding/tests/mfcembed/components/HelperAppDlg.cpp

Upcoming patch will supply a save/run dialog but the progress bar stuff won't work.

A working patch except for no progress dialog. The save/run dialog works fine and I think I'd like to checkin in its current state so the control can benefit from that and wait for the fix for bug 134523 for the progress meter.

Same patch without HelperAppDlg.cpp/h

Chak, would you be able to review the patch to add the helper app dialog to the control? I have two versions of the diff, the first contains HelperAppDlg.cpp and second doesn't. HelperAppDlg.cpp has been checked in already since it won't be built without checking in makefile changes, but feel free to review it anyway and I can submit fixes as diffs to the checked in version. It is more or less a Win32 version of your HelperAppDlg.cpp impl in MfcEmbed. The calls to invoke the progress meter are commented out due to bug 134523 Cheers, Adam

Comment on attachment 87260 [details] [diff] [review] Patch r=chak

Comment on attachment 87260 [details] [diff] [review] Patch sr=rpotts@netscape.com

Fix checked in. Verification (if anyone wants to try :): 1. Build mozilla/embedding/browser/activex/tests/cbrowse 2. Copy cbrowse.exe to mozilla/bin 3. cd mozilla/bin 4. regsvr32 mozctlx.dll 5. Run cbrowse and choose the Mozilla control 6. Load something which invokes the app helper dialog, e.g. file:///c:/WINDOWS/SYSTEM32/CALC.EXE 7. Verify app helper dialog appears