Closed
Bug 1262889
Opened 9 years ago
Closed 9 years ago
[traceback] AttributeError: 'NoneType' object has no attribute 'received_at'
Categories
(Shield :: General, defect)
Shield
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mythmon, Assigned: osmose)
References
Details
This happened during the demo yesterday.
https://sentry.prod.mozaws.net/operations/normandy-dev/group/323085/
[traceback] AttributeError: 'NoneType' object has no attribute 'received_at'
Stacktrace (most recent call last):
File "django/core/handlers/base.py", line 149, in get_response
response = self.process_exception_by_middleware(e, request)
File "django/core/handlers/base.py", line 147, in get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "django/utils/decorators.py", line 149, in _wrapped_view
response = view_func(request, *args, **kwargs)
File "django/views/decorators/cache.py", line 57, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File "django/contrib/admin/sites.py", line 244, in inner
return view(request, *args, **kwargs)
File "normandy/classifier/admin/views.py", line 14, in classifier_preview
bundle = Bundle.for_client(client, exclude=[match_sample_rate])
File "normandy/classifier/models.py", line 104, in for_client
return cls(recipes=recipes, country=client.country)
File "normandy/classifier/models.py", line 88, in __init__
self.recipes = sorted(recipes, key=lambda r: r.name) or []
File "normandy/classifier/models.py", line 101, in <genexpr>
if recipe.matches(client, exclude=exclude)
File "normandy/recipes/models.py", line 121, in matches
if not matcher(self, client):
File "normandy/recipes/models.py", line 156, in match_times
if recipe.start_time and recipe.start_time > client.request_time:
File "django/utils/functional.py", line 33, in __get__
res = instance.__dict__[self.name] = self.func(instance)
File "normandy/classifier/models.py", line 50, in request_time
return self.request.received_at
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mkelly
Comment 1•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/normandy
https://github.com/mozilla/normandy/commit/387c1ec51c3915cba111fda688a904ad0afbddcf
[bug 1262889] Pass the request to the Client in the preview view.
Fixes bug 1262889.
https://github.com/mozilla/normandy/commit/e9395f11221c9cc6e02c6dd740aa53b74062376d
Merge pull request #110 from Osmose/fix-classifier-preview-fo-real
[bug 1262889] Pass the request to the Client in the preview view.
Assignee | ||
Comment 2•9 years ago
|
||
This originally broke while I tried to submit the classifier preview without specifying a request time. This now works properly on dev: https://normandy.dev.mozaws.net/admin/classifier_preview?locale=en-US&country=US&release_channel=release&request_time_0=&request_time_1=
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Component: SHIELD → General
Product: Websites → Normandy
You need to log in
before you can comment on or make changes to this bug.
Description
•