Once we're confident that the new find code is working well enough, we need to remove the old find code, the pref, and the ugly switches in nsIWebBrowserFind.

Target mozilla 1.0 for this.

Moving Netscape owned 0.9.9 and 1.0 bugs that don't have an nsbeta1, nsbeta1+, topembed, topembed+, Mozilla0.9.9+ or Mozilla1.0+ keyword. Please send any questions or feedback about this to adt@netscape.com. You can search for "Moving bugs not scheduled for a project" to quickly delete this bugmail.

Here is an initial patch for what needs to change to remove the old find code. This bug is dependant on two others: there are dependencies on the old find code in mailnews and in powerplant embedding. Apparently the powerplant file is obsolete and we need not worry about it, but mail is more problematical, and may require that a mail person write a new dialog. This patch disables find within mail, which obviously isn't an acceptable solution but is enough to get this to compile and show that the list of dependencies is approximately right. I didn't make the removed files part of the patch. Here is the list of files to be removed: xpfe/components/find/resources/replacedialog.xul xpfe/components/find/resources/replacedialog.js xpfe/components/find/resources/locale/en-US/replacedialog.dtd editor/txtsvc/src/nsFindAndReplace.h editor/txtsvc/src/nsFindAndReplace.cpp xpfe/components/find/public/nsIFindComponent.idl xpfe/components/find/src/nsFindComponent.h xpfe/components/find/src/nsFindComponent.cpp embedding/browser/powerplant/source/CFindComponent.h embedding/browser/powerplant/source/CFindComponent.cpp

No traction from mail people on bug 141524; bumping this one out, sigh.

Varada says that mail code is not used and can be safely removed. So we can go ahead with this patch. Here's an updated version of the editor part of the patch, including the removed files.

Here's the xpfe part of the patch. Reviews, anyone?

Comment on attachment 89469 [details] [diff] [review] Editor patch whoo hoo! this is great. sr=alecf with an editor-module reviewer

Comment on attachment 89470 [details] [diff] [review] xpfe patch I like this one even more! :) sr=alecf

Kathy: do you have time to review this?

Comment on attachment 89469 [details] [diff] [review] Editor patch r=brade

Comment on attachment 89470 [details] [diff] [review] xpfe patch r=brade

Fixed, yesterday.

Although this bug is mentioned in CVS blame I can't find the patch that contains the error that I want to describe here so maybe it was checked in my mistake? Anyway the new error is this: There are lots of places in editor code with this or a similar construct: var htmlEditor = gEditor.QueryInterface(Components.interfaces.nsIHTMLEditor); if (!htmlEditor) return; Unfortunately in JS code QI throws on an error, it never returns null.

Oh, and I'm seeing lots of JS errors in HTML Mail: Error: gEditor has no properties Source File: chrome://editor/content/editor.js Line: 714 This message occurred 249 times during one message composition :-( Also, multiple times on the console window: An error occurred updating the cmd_smiley command An error occurred updating the cmd_advancedProperties command An error occurred updating the cmd_removeLinks command An error occurred updating the cmd_removeNamedAnchors command

You're right! That file should not have been checked in -- it's part of another bug. Sorry! Here's a patch to revert that file.

Bug 156918 apparently covers the backout, so I'm re-marking this fixed.

I looks like the (accidential?) checkin to editor.js also caused regression bug 156715.

Clean up verification of dated code change bus