Taskcluster graph JSON file with the patches, as much as I can say it includes both opt and dbg builds.

Comment on attachment 8739420 [details] [diff] [review] Add Mulet Linux debug builds to pine Review of attachment 8739420 [details] [diff] [review]: ----------------------------------------------------------------- Looking good, but I think there are a few things that need to be fixed before this is pushed. Probably because of the changes to the mozconfig for this build, you might want to push to try to see what that build looks like for you. Because this was also added to the try flags, you don't need to transplant any changes you made for pine into the try job_flags...it should already work. ::: b2g/dev/config/mozconfigs/linux64/mulet_dbg @@ +1,1 @@ > +MOZ_AUTOMATION_L10N_CHECK=0 I'm not an expert in mozconfigs, so you might want to have someone else review this piece to ensure it's doing what you want it to. ::: testing/taskcluster/tasks/branches/base_jobs.yml @@ +11,5 @@ > - Mulet Linux > types: > opt: > task: tasks/builds/mulet_linux.yml > + debug: Adding it here will make it scheduled on all pushes to branches inheriting this file, if that's the intent. ::: testing/taskcluster/tasks/branches/try/job_flags.yml @@ +44,5 @@ > opt: > task: tasks/builds/opt_linux64.yml > debug: > task: tasks/builds/dbg_linux64.yml > + linux64-mulet: Because this file inherits from base/job_flags.yml, and you added the debug build there, I do not think you need to add any changes here. ::: testing/taskcluster/tasks/builds/mulet_linux_dbg.yml @@ +10,5 @@ > + > + workerType: mulet-debug > + > + routes: > + - 'index.buildbot.branches.{{project}}.linux64-mulet' I'm not even sure if these buildbot index routes need to be here anymore, but other tasks have it so I suppose this isn't the right time to fix that. I would just check to make sure mulet-dbg is getting indexed the way you would want it to. Looking over the attached graph json it appears that it should be indexed correctly. @@ +20,5 @@ > + - 'docker-worker:relengapi-proxy:tooltool.download.public' > + > + payload: > + cache: > + level-{{level}}-{{project}}-build-mulet-dbg-linux-workspace: '/home/worker/workspace' Cache name here is: level-{{level}}-{{project}}-build-mulet-dbg-linux-workspace But the scope here is: level-{{level}}-{{project}}-build-mulet-linux-workspace' <--- missing dbg I'm not exactly sure about he build specifics if a separate cache is necessary for debug and opt builds. I know we've done that in the past, but I noticed that the linux desktop builds do not separate them out. Just something I noticed. The cache name and the name in the scope must match, no matter what's decided about splitting debug and opt out. @@ +44,5 @@ > + extra: > + treeherderEnv: > + - production > + - staging > + treeherder: You'll need to add task.extra.treeherder.collection.debug = true here for it to show up as a debug build Similar to this: https://dxr.mozilla.org/mozilla-central/source/testing/taskcluster/tasks/builds/dbg_linux64.yml#26

Comment on attachment 8739483 [details] [diff] [review] Add Mulet Linux debug builds to pine Review of attachment 8739483 [details] [diff] [review]: ----------------------------------------------------------------- ::: testing/taskcluster/tasks/branches/try/job_flags.yml @@ +48,5 @@ > + linux64-mulet: > + platforms: > + - Mulet Linux > + types: > + opt: So in the base/job_flags.yml that this file inherits from, mulet opt is already defined: https://dxr.mozilla.org/mozilla-central/source/testing/taskcluster/tasks/branches/base_jobs.yml#13 Do we want to enable debug only for try then and that's why we're not adding debug to the base/job_flags.yml?

Additions to try are for being able to push to try from pine. The job is also defined on pine/job_flags, so it should run for any job on pine, right?

Yea if it's in pine/job_flags then it should run

Comment on attachment 8739483 [details] [diff] [review] Add Mulet Linux debug builds to pine Review of attachment 8739483 [details] [diff] [review]: ----------------------------------------------------------------- This looks good to me and should work. I understand if you want to hold off on landing this until you're able to push to try again and verify it behaves how you would like it to.

Everything looks good, removing "tier" definition since it seems inconsistent with the rest of the use (mulet opt has no such field and yet it is tier 3).

triggering properly and treeherder filtering has been updated to add mulet debug as tier 3: https://treeherder.mozilla.org/#/jobs?repo=try&revision=eafe7ffebff0&filter-tier=1&filter-tier=2&filter-tier=3