Closed Bug 126319 Opened 23 years ago Closed 23 years ago

Implement getComputedStyle for text properties

Categories

(Core :: DOM: CSS Object Model, defect, P2)

Product:
Core
Component:
DOM: CSS Object Model
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.0

People

(Reporter: caillon, Assigned: caillon)

References

(
URL
)

Details

Attachments

(1 file, 2 obsolete files)

Patch v1.11
(deleted), patch
caillon
: review+
caillon
: superreview+
roc
: approval+
Details | Diff | Splinter Review
text-align and text-decoration are already implemented. This bug will cover text-indent, text-transform, letter-spacing, word-spacing, and white-space.
Attached patch Patch v1.0 (obsolete) (deleted) — — Splinter Review
Attached patch Patch v1.1 (obsolete) (deleted) — — Splinter Review
Fix two |val->SetString(NS_LITERAL_STRING(""));| to be the default values. Silly me :)
Attachment #70226 - Attachment is obsolete: true
r=hixie from a CSS point of view, as long as the sr= is familiar with this code and looks at the C++ carefully.
Comment on attachment 70350 [details] [diff] [review] Patch v1.1 Adding Hixie's review
Attachment #70350 - Flags: review+
->1.0
Blocks: 42417
Status: NEW → ASSIGNED
Keywords: patch
Priority: -- → P2
Target Milestone: --- → mozilla1.0
Comment on attachment 70350 [details] [diff] [review] Patch v1.1 sr=attinasi
Attachment #70350 - Flags: superreview+
Comment on attachment 70350 [details] [diff] [review] Patch v1.1 r=bzbarsky as well, looks great
Attached patch Patch v1.11 (deleted) — — Splinter Review
Same as attachment 70350 [details] [diff] [review], but moves a function definition to a more sane place. Was: GetTextDecoration(), GetVisibility(), GetTextIndent(), GetTextTransform()... Now: GetTextDecoration(), GetTextIndent(), GetTextTransform()... GetVisibility()
Attachment #70350 - Attachment is obsolete: true
Comment on attachment 72281 [details] [diff] [review] Patch v1.11 Transferring r=bzbarsky, sr=attinasi
Attachment #72281 - Flags: superreview+
Attachment #72281 - Flags: review+
checked in on the trunk. Thanks, Christopher!
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: