Closed
Bug 1263404
Opened 8 years ago
Closed 8 years ago
Single-element JSON arrays cannot be expanded
Categories
(DevTools :: JSON Viewer, defect, P1)
Tracking
(firefox47 unaffected, firefox48+ fixed, firefox49 verified)
VERIFIED
FIXED
Firefox 49
Tracking | Status | |
---|---|---|
firefox47 | --- | unaffected |
firefox48 | + | fixed |
firefox49 | --- | verified |
People
(Reporter: callahad, Assigned: Honza)
References
Details
(Keywords: DevAdvocacy)
Attachments
(2 files, 1 obsolete file)
(deleted),
video/webm
|
Details | |
(deleted),
patch
|
jryans
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
STR: 1. Visit https://accounts.google.com/.well-known/openid-configuration 2. Attempt to expand the `subject_types_supported` key What should happen: - I see ["public"] What actually happens: - I see nothing
Comment 1•8 years ago
|
||
Can't reproduce it FF Dev 47.0a2 (2016-04-10)
Reporter | ||
Comment 2•8 years ago
|
||
Ah, yep, only seeing this on Nightly.
OS: Unspecified → All
Hardware: Unspecified → All
Version: unspecified → 48 Branch
Comment 3•8 years ago
|
||
I was hit by this bug today. Waste half hour debugging my server side code... 48.0a2 (2016-05-03
Reporter | ||
Comment 4•8 years ago
|
||
Honza, could you take a look at this?
Flags: needinfo?(odvarko)
Priority: -- → P1
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → odvarko
Flags: needinfo?(odvarko)
Assignee | ||
Comment 6•8 years ago
|
||
Attachment #8748288 -
Flags: review?(jryans)
[Tracking Requested - why for this release]: Let's be sure to uplift to 48.
status-firefox47:
--- → unaffected
status-firefox48:
--- → affected
status-firefox49:
--- → affected
tracking-firefox48:
--- → ?
Attachment #8748288 -
Flags: review?(jryans) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 9•8 years ago
|
||
backed this out in https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=df57a1d196dc seems one of this 2 changes caused https://treeherder.mozilla.org/logviewer.html#?job_id=9144862&repo=fx-team#L0-L8834 can you take a look, thanks!
Flags: needinfo?(odvarko)
Assignee | ||
Comment 10•8 years ago
|
||
(In reply to Carsten Book [:Tomcat] from comment #9) > backed this out in > https://treeherder.mozilla.org/#/jobs?repo=fx-team&revision=df57a1d196dc > seems one of this 2 changes caused > https://treeherder.mozilla.org/logviewer.html#?job_id=9144862&repo=fx- > team#L0-L8834 > > can you take a look, thanks! Ah yes, sorry, the failure totally make sense. New patch attached. - The original fix stays the same - JSON view test adopted - One React warning fixed (worthless binding) Try push https://treeherder.mozilla.org/#/jobs?repo=try&revision=72170dd3faea Let's see how that try goes! Honza
Attachment #8748288 -
Attachment is obsolete: true
Flags: needinfo?(odvarko)
Attachment #8748618 -
Flags: review?(jryans)
Attachment #8748618 -
Flags: review?(jryans) → review+
Assignee | ||
Comment 12•8 years ago
|
||
Try looks good, let's try to ship this. Honza
Keywords: checkin-needed
Comment 13•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/2451d15ff234
Keywords: checkin-needed
Comment 14•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2451d15ff234
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 15•8 years ago
|
||
Tracking for 48 - do we want to uplift this to 48?
Flags: needinfo?(odvarko)
Assignee | ||
Comment 16•8 years ago
|
||
Comment on attachment 8748618 [details] [diff] [review] bug1263404.patch Approval Request Comment [Feature/regressing bug #]: JSON Viewer [User impact if declined]: See https://bug1263404.bmoattachments.org/attachment.cgi?id=8748271 [Describe test coverage new/current, TreeHerder]: in Nightly [Risks and why]: Low [String/UUID change made/needed]: n/a
Flags: needinfo?(odvarko)
Attachment #8748618 -
Flags: approval-mozilla-aurora?
Comment 17•8 years ago
|
||
Comment on attachment 8748618 [details] [diff] [review] bug1263404.patch Improve a new feature, taking it.
Attachment #8748618 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 18•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/30ef13031f3b
Comment 19•8 years ago
|
||
I have reproduced this bug with nightly 48.0a1 (2016-04-09) on Windows 7, 64 Bit! This bug's fix is verified on latest Developer Edition,latest Beta. Build ID 20160708004052 User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0 Build ID 20160714050942 User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:48.0) Gecko/20100101 Firefox/48.0
Comment 20•8 years ago
|
||
Thanks for testing Rahman! I also verified this using latest DevEdition 49.0a2 on Mac OS X 10.10.5
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•