Closed
Bug 1263474
Opened 9 years ago
Closed 9 years ago
convert three tests in image/test/mochitest/chrome.ini to mochitest-plain
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(1 file)
(deleted),
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
These were disabled at the time of bug 1261158. But bug 1262269 shows they don't need to be.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8739801 -
Flags: review?(bugmail.mozilla)
Updated•9 years ago
|
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Comment on attachment 8739801 [details] [diff] [review]
patch
Review of attachment 8739801 [details] [diff] [review]:
-----------------------------------------------------------------
::: image/test/mochitest/mochitest.ini
@@ +107,5 @@
> [test_bug89419-2.html]
> [test_bug1180105.html]
> [test_bug1217571.html]
> +[test_animation.html]
> +[test_animation2.html]
They might still need to be disabled on b2g/android, since the chrome.ini had that. AFAICT you haven't done a try push to verify they pass on android.
Attachment #8739801 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #2)
> They might still need to be disabled on b2g/android, since the chrome.ini
> had that. AFAICT you haven't done a try push to verify they pass on android.
Ah, I thought I had, but of course they are disabled by default at the start of the file, and when I checked the try server log it was "TEST-SKIP" which I must have read as "TEST-PASS" when I originally checked. I'll disable on b2g and android.
Comment 5•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Assignee | ||
Comment 6•9 years ago
|
||
Uplifted to aurora because I'm told e10s test fixes should be uplifted to aurora
https://hg.mozilla.org/releases/mozilla-aurora/rev/3312754269d285ad416da1d54cf07e6a163ce479
Assignee | ||
Updated•9 years ago
|
status-firefox47:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•