Closed
Bug 1263761
Opened 9 years ago
Closed 9 years ago
Improve defaultSearch core-ping docs for custom search engines
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox48 fixed)
RESOLVED
FIXED
Firefox 48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/45605/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/45605/
Attachment #8740168 -
Flags: review?(gfritzsche)
Comment 2•9 years ago
|
||
Comment on attachment 8740168 [details]
MozReview Request: Bug 1263761 - Update defaultSearch in core ping docs for custom search engines. r=gfritzsche
https://reviewboard.mozilla.org/r/45605/#review42261
Thanks for keeping the docs up-to-date.
::: toolkit/components/telemetry/docs/core-ping.rst:81
(Diff revision 1)
> +This field can also be ``null`` when a custom search engine is set as the
> +default.
```
... is set as the default (`bug XXX <https:// ...>`_ will fix this).
```
Attachment #8740168 -
Flags: review?(gfritzsche) → review+
Assignee | ||
Comment 3•9 years ago
|
||
https://reviewboard.mozilla.org/r/45605/#review42261
> ```
> ... is set as the default (`bug XXX <https:// ...>`_ will fix this).
> ```
This is actually intended to land after bug 1249288. See https://bugzilla.mozilla.org/show_bug.cgi?id=1249288#c75
I'm going to leave the comment the way it is.
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/6c9c59550600d7523a7d58d23c1c9a6bce91b0f1
Bug 1263761 - Update defaultSearch in core ping docs for custom search engines. r=gfritzsche
Comment 5•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•