Closed Bug 1263941 Opened 9 years ago Closed 9 years ago

History is not displayed in the 3-dot menu if History panel is set as default after it was hidden

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox45 unaffected, firefox46 affected, firefox47 verified, firefox48 verified, fennec47+)

Status:
VERIFIED FIXED
Milestone:
Firefox 48
Tracking Flags:
Tracking Status
firefox45 --- unaffected
firefox46 --- affected
firefox47 --- verified
firefox48 --- verified
fennec 47+ ---

People

(Reporter: sflorean, Assigned: liuche)

References

Details

Attachments

(2 files)

screenshot.png
(deleted), image/png
Details
MozReview Request: Bug 1263941 - History is not displayed in the 3-dot menu if History panel is set as default after it was hidden. r=sebastian
(deleted), text/x-review-board-request
sebastian
: review+
ritu
: approval-mozilla-beta+
Details
Attached image screenshot.png (deleted) —
Environment: Device: Asus Transformer Pad (Android 4.2.1); Build: Nightly 48.0a1 (2016-04-11); Steps to reproduce: 1. Go to Settings->General->Home; 2. Hide History panel; 3. Go back to about:home and tap the 3-dot menu button; 4. Observe that Bookmarks and History are not displayed; 5. Go to Settings->General->Home; 6. Tap on History->Set as default; 7. Repeat step 3. Expected result: History is displayed in the 3-dot menu. Actual result: History is not displayed in the 3-dot menu. Notes: Please check the attached screenshot. Also reproducible with Bookmarks panel.
tracking-fennec: --- → ?
I didn't add a listener into setDefault, so that's all that we need to do for this. I'll take care of this!
Assignee: nobody → liuche
Blocks: combined-history
Blocks: home-panels
No longer blocks: combined-history
Comment on attachment 8743410 [details] MozReview Request: Bug 1263941 - History is not displayed in the 3-dot menu if History panel is set as default after it was hidden. r=sebastian https://reviewboard.mozilla.org/r/47743/#review44791
Attachment #8743410 - Flags: review?(s.kaspari) → review+
No longer blocks: home-panels
I don't think this blocks us shipping the menu items in 46, but we should uplift to 47.
tracking-fennec: ? → 47+
https://hg.mozilla.org/mozilla-central/rev/2570cd8ec0bd
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 48
Verified as fixed in build 48.0a2 2016-04-26; Device: Asus Transformer Pad (Android 4.2.1).
status-firefox48: fixed → verified
Sigh, this never got uplifted... can we uplift this for 47?
Flags: needinfo?(liuche)
Comment on attachment 8743410 [details] MozReview Request: Bug 1263941 - History is not displayed in the 3-dot menu if History panel is set as default after it was hidden. r=sebastian Approval Request Comment [Feature/regressing bug #]: Bug in original patches in bug 1255077 and bug 1231792 [User impact if declined]: History/Bookmark panel set as default from hidden won't show up in the 3-dot menu [Describe test coverage new/current, TreeHerder]: Nightly, Aurora [Risks and why]: low, adding one extra case for triggering 3-dot menu visibility [String/UUID change made/needed]: none
Flags: needinfo?(liuche)
Attachment #8743410 - Flags: approval-mozilla-beta?
Verified based on comment 7.
Status: RESOLVED → VERIFIED
Comment on attachment 8743410 [details] MozReview Request: Bug 1263941 - History is not displayed in the 3-dot menu if History panel is set as default after it was hidden. r=sebastian Fix was verified on 48, Beta47+
Attachment #8743410 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed on Firefox 47 Beta 4 on Samsung Galaxy S6 Edge (Android 5.1.1)
status-firefox47: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: