Open Bug 1264002 Opened 8 years ago Updated 2 years ago

DOM panel: implement unit tests

Categories

(DevTools :: DOM, enhancement, P2)

enhancement

Tracking

(Not tracked)

People

(Reporter: Honza, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

This is a follow up for bug 1201475

See also Lin's comment:
https://bugzilla.mozilla.org/show_bug.cgi?id=1201475#c64

In the long term, I'd like to see if we could add more unit/integration
tests for this. Just for the sake of discussion, what functionality would we
miss if these tests were structured like the following?
 
- 1 chrome test that tests the store directly. It calls dispatch on the
store with an action. The store starts in state A and the test makes sure it
ends up in state B
- 1 chrome test that tests the components. Given state A, it makes sure that
it renders as expected. Same for B.
- 1 test that ensures the expected action is dispatched when a button is
pressed

Might depend on bug 1262865

Honza
Severity: normal → enhancement
Component: Developer Tools → Developer Tools: DOM
Priority: -- → P1
A P1 that hasn't moved for a year doesn't make sense. P1s are supposed to be crashes, data loss, security bugs, tools just not working at all. Basically things that we must fix right now without delay.
Do we have better tests now? Do we still need more? If yes, maybe we at least need to make this bug more actionable, by listing which tests we need, where they should live, how they be implemented. Maybe by filing sub-bugs as well. So that anyone can come in and pick these up.
Priority: P1 → P2
Product: Firefox → DevTools
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.