Closed
Bug 1264167
Opened 9 years ago
Closed 9 years ago
[TV][Home] Renaming card under folder does not take effect immediately after inputing new name.
Categories
(Firefox OS Graveyard :: Gaia::TV::Home, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Fischer, Assigned: Fischer)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file)
STR:
1) Ping one app to Home
2) Add that pinged app to a folder
3) Rename that app under folder
Expected:
The card name changes after inputing new name
Actual:
The card name dose not change
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → fliu
Assignee | ||
Updated•9 years ago
|
Summary: [TV][Home] Renaming card under folder does not take effect immediately after inputing new new. → [TV][Home] Renaming card under folder does not take effect immediately after inputing new name.
Assignee | ||
Updated•9 years ago
|
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8740798 [details]
[gaia] Fischer-L:bug_1264167-rename-card-under-folder-issue > mozilla-b2g:master
@Rex,
When renaming card, cardManager and home do not handle the case of renaming card under folder.
As a result, renaming card under folder does not take effect immediately after inputing new name.
This patch check if card under folder is being renamed and do corresponding handling to fix the issue.
Thanks
Attachment #8740798 -
Flags: review?(rexboy)
Comment 3•9 years ago
|
||
Comment on attachment 8740798 [details]
[gaia] Fischer-L:bug_1264167-rename-card-under-folder-issue > mozilla-b2g:master
We should have a way that works more consistently with other parts of the code. Please see my comments.
Attachment #8740798 -
Flags: review?(rexboy)
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8740798 [details]
[gaia] Fischer-L:bug_1264167-rename-card-under-folder-issue > mozilla-b2g:master
@Rex,
Modify to utilize Folder-type card's card-updated event to update new name, like the use of card-removed and card-inserted event, thanks.
Attachment #8740798 -
Flags: review?(rexboy)
Comment 5•9 years ago
|
||
Comment on attachment 8740798 [details]
[gaia] Fischer-L:bug_1264167-rename-card-under-folder-issue > mozilla-b2g:master
Looks good to me. Thanks!
Attachment #8740798 -
Flags: review?(rexboy) → review+
Assignee | ||
Comment 6•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•