Lin Clark [:linclark] Assignee
	Description • 9 years ago

See Bug 1257552

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 2 • 8 years ago

So, if I understand correctly, this needs another bug report related to the missing provider, right?
(all outputs are empty atm)

Honza

	Lin Clark [:linclark] Assignee
	Comment 3 • 8 years ago

There is a bug, and this TODO in the file:

> // @TODO This is not how this feature should actually work
> // See Bug 1282463 - Reps: ensure that grip arrays work even when a provider is not provided

were you thinking of something else?

	Jan Honza Odvarko [:Honza] (always need-info? me)
	Comment 4 • 8 years ago

Comment on attachment 8765477 [details] [diff] [review]
Bug1264684.patch

Review of attachment 8765477 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Lin Clark [:linclark] from comment #3)
> There is a bug, and this TODO in the file:
> 
> > // @TODO This is not how this feature should actually work
> > // See Bug 1282463 - Reps: ensure that grip arrays work even when a provider is not provided
Ah, good.

Honza

	Lin Clark [:linclark] Assignee
	Comment 5 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/63150/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63150/

	Lin Clark [:linclark] Assignee
	Comment 6 • 8 years ago

Comment on attachment 8769172 [details]
Bug 1264684 - [rep tests] Add tests for grip-array rep.

Carrying over the r+

	Pulsebot
	Comment 7 • 8 years ago

Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/4089e4a43dc6
[rep tests] Add tests for grip-array rep. r=Honza

	Carsten Book [:Tomcat]
	Comment 8 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/4089e4a43dc6