Closed
Bug 1264684
Opened 9 years ago
Closed 8 years ago
[rep tests] Add tests for grip-array rep
Categories
(DevTools :: Shared Components, enhancement, P1)
DevTools
Shared Components
Tracking
(firefox50 fixed)
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: linclark, Assigned: linclark)
References
Details
(Whiteboard: [devtools-html])
Attachments
(1 file, 1 obsolete file)
See Bug 1257552
Updated•9 years ago
|
Severity: normal → enhancement
Whiteboard: [devtools-html]
Updated•9 years ago
|
Blocks: devtools-html-2
Updated•9 years ago
|
Flags: qe-verify-
Priority: -- → P2
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → lclark
Updated•8 years ago
|
Status: NEW → ASSIGNED
Iteration: --- → 50.2
Priority: P2 → P1
Comment 2•8 years ago
|
||
So, if I understand correctly, this needs another bug report related to the missing provider, right? (all outputs are empty atm) Honza
Flags: needinfo?(lclark)
Assignee | ||
Comment 3•8 years ago
|
||
There is a bug, and this TODO in the file:
> // @TODO This is not how this feature should actually work
> // See Bug 1282463 - Reps: ensure that grip arrays work even when a provider is not provided
were you thinking of something else?
Flags: needinfo?(lclark)
Comment 4•8 years ago
|
||
Comment on attachment 8765477 [details] [diff] [review] Bug1264684.patch Review of attachment 8765477 [details] [diff] [review]: ----------------------------------------------------------------- (In reply to Lin Clark [:linclark] from comment #3) > There is a bug, and this TODO in the file: > > > // @TODO This is not how this feature should actually work > > // See Bug 1282463 - Reps: ensure that grip arrays work even when a provider is not provided Ah, good. Honza
Attachment #8765477 -
Flags: review?(odvarko) → review+
Updated•8 years ago
|
Iteration: 50.2 - Jul 4 → 50.3 - Jul 18
Assignee | ||
Comment 5•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/63150/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/63150/
Attachment #8769172 -
Flags: review?(odvarko)
Assignee | ||
Updated•8 years ago
|
Attachment #8765477 -
Attachment is obsolete: true
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8769172 [details] Bug 1264684 - [rep tests] Add tests for grip-array rep. Carrying over the r+
Attachment #8769172 -
Flags: review?(odvarko) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/4089e4a43dc6 [rep tests] Add tests for grip-array rep. r=Honza
Keywords: checkin-needed
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4089e4a43dc6
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•