Closed
Bug 1264688
Opened 9 years ago
Closed 8 years ago
[rep tests] Add tests for number rep
Categories
(DevTools :: Shared Components, enhancement, P1)
DevTools
Shared Components
Tracking
(firefox50 fixed)
| Tracking | Status | |
|---|---|---|
| firefox50 | --- | fixed |
People
(Reporter: linclark, Assigned: linclark)
References
Details
(Whiteboard: [devtools-html])
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Honza
:
review+
|
Details | Diff | Splinter Review |
See Bug 1257552
|
||
Updated•9 years ago
|
Severity: normal → enhancement
Whiteboard: [devtools-html]
|
|
||
Updated•9 years ago
|
Blocks: devtools-html-2
|
|
||
Updated•9 years ago
|
Flags: qe-verify-
Priority: -- → P2
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → lclark
|
|
||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Iteration: --- → 50.2
Priority: P2 → P1
|
|
Assignee | |
Comment 1•8 years ago
|
||
If a grip comes back with the type -0, then I don't think it's handled... at least that's what the test seems to indicate. Honza, do you think this is an oversight, or is it intentional?
Flags: needinfo?(odvarko)
|
||
Comment 2•8 years ago
|
||
(In reply to Lin Clark [:linclark] from comment #1) > Created attachment 8764717 [details] [diff] [review] > Bug1264688.patch > > If a grip comes back with the type -0, then I don't think it's handled... True, I am seeing 'Object' instead of '-0'. It's a bug in Number.stringify() Please file a bug I can fix it. Honza
Flags: needinfo?(odvarko)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8764717 -
Attachment is obsolete: true
|
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8766809 [details] [diff] [review] Bug1264688.patch Review of attachment 8766809 [details] [diff] [review]: ----------------------------------------------------------------- Looks good and passes on my machine. Please don't forget to file a bug related to wrong rendering of '-0' Honza
Attachment #8766809 -
Flags: review?(odvarko) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/f0aae53c43a3 [rep tests] Add tests for number rep. r=Honza
Keywords: checkin-needed
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f0aae53c43a3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•