Closed
Bug 1264701
Opened 9 years ago
Closed 8 years ago
Move url utils to rep-utils.js
Categories
(DevTools :: Shared Components, enhancement, P1)
DevTools
Shared Components
Tracking
(firefox50 fixed)
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: linclark, Assigned: gasolin)
References
Details
(Whiteboard: [reserve-html])
Attachments
(1 file)
See Bug 1257552
Updated•9 years ago
|
Severity: normal → enhancement
Whiteboard: [devtools-html]
Updated•9 years ago
|
Blocks: devtools-html-2
Updated•8 years ago
|
Flags: qe-verify-
Priority: -- → P2
Reporter | ||
Comment 1•8 years ago
|
||
It turns out this isn't a rep. Honza, could these functions move to rep-utils? Or would you rather keep them in their own file?
Flags: needinfo?(odvarko)
Reporter | ||
Updated•8 years ago
|
Summary: [rep tests] Add tests for url rep → Move url utils to rep-utils.js
Updated•8 years ago
|
Priority: P2 → P3
Whiteboard: [devtools-html] → [reserve-html]
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/63612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/63612/
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8769978 [details]
Bug 1264701 - combine url utils to rep-utils.js;
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63612/diff/1-2/
Attachment #8769978 -
Flags: review?(lclark)
Assignee | ||
Comment 5•8 years ago
|
||
The patch just combine url.js into rep-utils.js and change the related imports.
Reporter | ||
Comment 6•8 years ago
|
||
Comment on attachment 8769978 [details]
Bug 1264701 - combine url utils to rep-utils.js;
https://reviewboard.mozilla.org/r/63612/#review60648
Looks like something went wrong in the copy-ing. The tests aren't passing.
Attachment #8769978 -
Flags: review?(lclark) → review-
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8769978 [details]
Bug 1264701 - combine url utils to rep-utils.js;
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63612/diff/2-3/
Attachment #8769978 -
Flags: review- → review?(lclark)
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8769978 [details]
Bug 1264701 - combine url utils to rep-utils.js;
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63612/diff/3-4/
Assignee | ||
Comment 9•8 years ago
|
||
https://reviewboard.mozilla.org/r/63612/#review60648
Thanks for review. The reason of build failure is because I forget to remove `url.js` from moz.build.
Update the patch and push a new try to see the result. Will ask review again once test passed.
Assignee | ||
Comment 10•8 years ago
|
||
Comment on attachment 8769978 [details]
Bug 1264701 - combine url utils to rep-utils.js;
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63612/diff/4-5/
Assignee | ||
Comment 11•8 years ago
|
||
Comment on attachment 8769978 [details]
Bug 1264701 - combine url utils to rep-utils.js;
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/63612/diff/5-6/
Reporter | ||
Comment 12•8 years ago
|
||
Comment on attachment 8769978 [details]
Bug 1264701 - combine url utils to rep-utils.js;
https://reviewboard.mozilla.org/r/63612/#review60994
LGTM, thanks!
Attachment #8769978 -
Flags: review?(lclark) → review+
Comment 14•8 years ago
|
||
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/12a9cf4fbb14
combine url utils to rep-utils.js; r=linclark
Keywords: checkin-needed
Comment 15•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Updated•8 years ago
|
Iteration: --- → 50.3 - Jul 18
Priority: P3 → P1
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•