Closed
Bug 1264777
Opened 9 years ago
Closed 9 years ago
three dot menu cut off on Android N preview 2
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox45 affected, firefox46 affected, firefox47 affected, firefox48 affected, fennec47+)
People
(Reporter: kbrosnan, Assigned: sebastian)
References
Details
Attachments
(1 file)
|
(deleted),
image/png
|
Details |
Screenshot of the cut off menu
The three dot menu is cut off on Android N preview 2 running on an Nexus 5x.
|
Reporter | |
Updated•9 years ago
|
tracking-fennec: --- → ?
|
|
Reporter | |
Updated•9 years ago
|
|
Assignee | |
Comment 1•9 years ago
|
||
This is happening on the N9 too.
|
||
Comment 2•9 years ago
|
||
This might be a google bug, but we should figure out what's going on here.
Assignee: nobody → s.kaspari
tracking-fennec: ? → 47+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Yeah, I already looked a bit into this. It seems like our calculations are off on Android N here:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/menu/MenuPopup.java#75-76
We might not need that class anymore since we now can use Android's PopupMenu:
http://developer.android.com/reference/android/widget/PopupMenu.html
(This might apply to even more menu code in general)
|
|
Assignee | |
Comment 4•9 years ago
|
||
I tried all kinds of things to get the positioning right on Android N and previous versions. However this seems to be a regression in Preview 2 when using WRAP_CONTENT with a PopupWindow. I was able to reproduce this with a sample project.
I filed a bug for that here:
https://code.google.com/p/android/issues/detail?id=208451
|
|
Assignee | |
Comment 6•9 years ago
|
||
I copied an old version of PopupWindow into the tree and stripped some internal APIs. With that it's working without issues. So it's definitely a regression in Android.
In addition to that I added some more info to the (Android) bug report.
|
|
Assignee | |
Comment 7•9 years ago
|
||
From the Android bug tracker:
> Hi we wont see this issue on the internal build which is ahead of preview build
> and fix should be available in future releases. Do let us know if you still see
> this issue on future releases
So this will hopefully be fixed with preview 3.
|
|
Reporter | |
Comment 8•9 years ago
|
||
It is!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•