Closed
Bug 1265008
Opened 9 years ago
Closed 8 years ago
Enable the Kinto.js OneCRL client for release channels
Categories
(Cloud Services :: Firefox: Common, defect)
Cloud Services
Firefox: Common
Tracking
(firefox50 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: mgoodwin, Assigned: mgoodwin)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Updated•9 years ago
|
Summary: Enable the Kinto.js OneCRL client → Enable the Kinto.js OneCRL client for release channels
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/67718/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67718/
Attachment #8775527 -
Flags: review?(MattN+bmo)
Comment 2•8 years ago
|
||
Comment on attachment 8775527 [details]
Bug 1265008 - Enable kinto.js OneCRL client for release channels.
https://reviewboard.mozilla.org/r/67718/#review64850
r=me assuming desktop and mobile QA have signed off and there are no regressions.
Attachment #8775527 -
Flags: review?(MattN+bmo) → review+
Comment 3•8 years ago
|
||
Specifically I think there should be an email to release-drivers about the intent to ship with QA signing off because this affects the security of our products.
Assignee | ||
Comment 4•8 years ago
|
||
I won't land this until I have QA approval.
Matt, is there a bug for QA on this feature?
Flags: needinfo?(mwobensmith)
Comment 5•8 years ago
|
||
There is no bug specifically for QA, on the client side at least. I don't know if there should be.
As far as signing off, we still have bug 1289841, which technically looks like existing behavior and probably not blocking. However, that plus other issues have slowed me down, and I'm not ready to say today that I'd sign off. Assuming I can work around that bug, and that my remaining testing is OK, I could be ready to sign off by early next week.
Flags: needinfo?(mwobensmith)
Comment 6•8 years ago
|
||
Based on conversation with Mark, and the last two hours of testing, I am going to go ahead and give this the green light. Working around bug 1289841 is a pain - especially with the slow syncing between AMO/Kinto - but I've been able to accomplish the test tasks I set out to achieve.
I will continue to test, especially after we have a fix for the above bug, as it should make things easier.
Pushed by mgoodwin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/154bf0638857
Enable kinto.js OneCRL client for release channels. r=MattN
Comment 8•8 years ago
|
||
bugherder |
Comment 11•8 years ago
|
||
Thanks Mark :)
You need to log in
before you can comment on or make changes to this bug.
Description
•