Closed
Bug 1265282
Opened 9 years ago
Closed 9 years ago
crash in mozilla::layers::AssertD3D11Compositor
Categories
(Core :: Graphics, defect)
Tracking
()
VERIFIED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: nical)
References
Details
(Keywords: crash, Whiteboard: [gfx-noted])
Crash Data
Attachments
(1 file)
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
This bug was filed from the Socorro interface and is
report bp-92f7b1ec-a60d-40bc-951c-4d0442160416.
=============================================================
8 crashes with this signature have been seen, the first occurring in Nightly 20160415030231.
The diagnostic assertion triggering the crash was added by bug 1258768.
Updated•9 years ago
|
Whiteboard: [gfx-noted]
Assignee | ||
Comment 2•9 years ago
|
||
This happens after a device reset. We have hardware decoded video frames still in flights and they are received by a BasicCompositor rather than a D3D11 one and that's what causes the assertion to blow up.
In release, the diagnostic assert will just return null and the caller null-checks so we'll be good. I'll have to replace the assertion with a warning for beta/aurora users for now because it is hard to prevent this situation to happen when having a device reset.
More worrying: this means that before bug 1258768 we were potentially unsafely casting a BasicCompositor* into a D3D11COmpositor* if having a device reset while playing a video, so we need to patch that up and uplift it.
Assignee: nobody → nical.bugzilla
Flags: needinfo?(nical.bugzilla)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8742905 -
Flags: review?(dvander)
Attachment #8742905 -
Flags: review?(dvander) → review+
Blocks: 1266421
Comment 5•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Reporter | ||
Comment 6•9 years ago
|
||
Has not occurred in versions after Nightly 20160422030223. Thank you for the fix.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•