Closed Bug 1265497 Opened 9 years ago Closed 9 years ago

Not-so-great favicon handling

Categories

(Firefox for Android Graveyard :: Favicon Handling, defect)

Product:
Firefox for Android Graveyard
Component:
Favicon Handling
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox49 fixed, relnote-firefox 49+)

Status:
VERIFIED FIXED
Milestone:
Firefox 49
Tracking Flags:
Tracking Status
firefox49 --- fixed
relnote-firefox --- 49+

People

(Reporter: antlam, Assigned: sebastian)

References

Details

Attachments

(4 files)

Screen Shot 2016-04-18 at 12.20.11 PM.png
(deleted), image/png
Details
not-so-great-icons.png
(deleted), image/png
antlam
: feedback+
Details
50percent.png
(deleted), image/png
antlam
: feedback+
Details
MozReview Request: Bug 1265497 - FaviconView: New favicon background with rounded corners. r?ahunt
(deleted), text/x-review-board-request
ahunt
: review+
Details
In https://bugzilla.mozilla.org/show_bug.cgi?id=1228680#c11, we identified there's a case where we have an icon, so we'll use it, but it's not IDEAL. So here's how we'll handle that situation.
1) Use the not-so-great favicon, centered. 2) Detect dominant color 3) Fill remaining space with color from (2). In most cases, it'll look something like this. Home panels list (left), possible top sites (right).
Flags: needinfo?(s.kaspari)
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Flags: needinfo?(s.kaspari)
Attached image not-so-great-icons.png (deleted) —
This is a WIP screenshot. I kept the 27.5% color (dominant color & 0x46FFFFFF). It looks much better but I'm not super happy with it yet. What do you think. Your mock seems to use a darker version of the dominant color (or: less transparent) - what values did you use?
Attachment #8742940 - Flags: feedback?(alam)
Comment on attachment 8742940 [details] not-so-great-icons.png This is looking great! I'm not sure why the 27.5% is there, since I don't think we use that value anywhere else in our product. But I do like the transparency in that it separates the favicon visually. I suggest we try a cleaner % value (not 100% since it looks broken). Can we try just making it 50%?
Flags: needinfo?(s.kaspari)
Attachment #8742940 - Flags: feedback?(alam) → feedback+
Attached image 50percent.png (deleted) —
Flags: needinfo?(s.kaspari)
Comment on attachment 8743274 [details] 50percent.png > Can we try just making it 50%? Yep. :)
Attachment #8743274 - Flags: feedback?(alam)
Comment on attachment 8743274 [details] 50percent.png Awesome!
Attachment #8743274 - Flags: feedback?(alam) → feedback+
Comment on attachment 8743318 [details] MozReview Request: Bug 1265497 - FaviconView: New favicon background with rounded corners. r?ahunt Review request updated; see interdiff: https://reviewboard.mozilla.org/r/47711/diff/1-2/
Attachment #8743318 - Attachment description: MozReview Request: Bug 1265497 - FaviconView: New favicon backgroundi with rounded corners. r? → MozReview Request: Bug 1265497 - FaviconView: New favicon background with rounded corners. r?ahunt
Attachment #8743318 - Flags: review?(ahunt)
Comment on attachment 8743318 [details] MozReview Request: Bug 1265497 - FaviconView: New favicon background with rounded corners. r?ahunt https://reviewboard.mozilla.org/r/47711/#review44561 Nice!
Attachment #8743318 - Flags: review?(ahunt) → review+
No longer blocks: home-panels
https://hg.mozilla.org/mozilla-central/rev/1a4b7ff56f65
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Verified as fixed in Firefox Nightly 49.0a1 (2016-05-18) on Motorola Nexus 6 (Android 6.0)
Status: RESOLVED → VERIFIED
Release Note Request (optional, but appreciated) [Why is this notable]: [Suggested wording]: Polish of displaying favicons [Links (documentation, blog post, etc)]:
relnote-firefox: --- → ?
Relnote 49+ added "Visual improvements in favicon display"
relnote-firefox: ? → 49+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: