Closed Bug 1265541 Opened 9 years ago Closed 9 years ago

cubeb doesn't build with libc++ because of #defining unique_ptr

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ehsan.akhgari, Unassigned)

References

Details

Attachments

(1 file)

0:17.40 In file included from /Users/ehsan/moz/src/media/libcubeb/tests/test_resampler.cpp:18: 0:17.40 In file included from /Users/ehsan/Downloads/clang+llvm-3.7.0-x86_64-apple-darwin/bin/../include/c++/v1/iostream:40: 0:17.40 In file included from /Users/ehsan/Downloads/clang+llvm-3.7.0-x86_64-apple-darwin/bin/../include/c++/v1/istream:163: 0:17.40 In file included from /Users/ehsan/Downloads/clang+llvm-3.7.0-x86_64-apple-darwin/bin/../include/c++/v1/ostream:140: 0:17.40 /Users/ehsan/Downloads/clang+llvm-3.7.0-x86_64-apple-darwin/bin/../include/c++/v1/locale:230:9: error: no template named 'UniquePtr' in namespace 'std::__1'; did you mean simply 'UniquePtr'? 0:17.40 typedef _VSTD::unique_ptr<__locale_struct, decltype(&freelocale)> __locale_unique_ptr; 0:17.40 ^~~~~~~ 0:17.40 /Users/ehsan/Downloads/clang+llvm-3.7.0-x86_64-apple-darwin/bin/../include/c++/v1/__config:388:15: note: expanded from macro '_VSTD' 0:17.40 #define _VSTD std::_LIBCPP_NAMESPACE 0:17.40 ^ 0:17.40 /Users/ehsan/moz/src/obj-ff-clang-plugin.noindex/dist/include/mozilla/UniquePtr.h:188:7: note: 'UniquePtr' declared here 0:17.40 class UniquePtr 0:17.40 ^
Comment on attachment 8742510 [details] [diff] [review] Make the unique_ptr replacment technique compatible with libc++ Review of attachment 8742510 [details] [diff] [review]: ----------------------------------------------------------------- I'll land this today with a cubeb uplift, there are a couple other things we need and are present upstream.
Attachment #8742510 - Flags: review?(padenot) → review+
Depends on: 1265692
Thanks!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: