Closed
Bug 1265718
Opened 8 years ago
Closed 8 years ago
Decouple fronts from actors in animation inspector.
Categories
(DevTools :: Inspector: Animations, enhancement, P1)
DevTools
Inspector: Animations
Tracking
(Not tracked)
People
(Reporter: ejpbruel, Assigned: ejpbruel)
References
Details
Attachments
(2 files)
(deleted),
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Updated•8 years ago
|
Severity: normal → enhancement
Whiteboard: [devtools-html]
Updated•8 years ago
|
Flags: qe-verify-
Priority: -- → P2
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → ejpbruel
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8751326 -
Flags: review?(jryans)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8751327 -
Flags: review?(jryans)
Updated•8 years ago
|
Status: NEW → ASSIGNED
Iteration: --- → 49.2 - May 23
Priority: P2 → P1
Attachment #8751326 -
Flags: review?(jryans) → review+
Attachment #8751327 -
Flags: review?(jryans) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Try push for the patch to decouple AnimationPlayerFront from AnimationPlayerActor: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3483dbe4173
Assignee | ||
Comment 4•8 years ago
|
||
Previous try push for patch to decouple AnimationPlayerFront from AnimationPlayer had test failures due to capitalisation errors. New try push with issues addressed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fefef0a85b11
Assignee | ||
Updated•8 years ago
|
Keywords: leave-open
Assignee | ||
Comment 5•8 years ago
|
||
Try push for patch to decouple AnimationPlayerFront from AnimationPlayer looks good, but I had to rebase over some ESLint fixes. Here's another try push to make sure I didn't break anything during rebase: https://treeherder.mozilla.org/#/jobs?repo=try&revision=941b520f902f
Assignee | ||
Comment 6•8 years ago
|
||
Try push for the patch to decouple AnimationsFront from AnimationsActor: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb05e74ab75b
Comment 9•8 years ago
|
||
sorry had to back this out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=9491138&repo=fx-team
Flags: needinfo?(ejpbruel)
Comment 10•8 years ago
|
||
Backout: https://hg.mozilla.org/integration/fx-team/rev/74fe05a5f015
Assignee | ||
Comment 11•8 years ago
|
||
Try push for the patch to decouple AnimationsFront from AnimationsActor: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d54ab0f97b12
Flags: needinfo?(ejpbruel)
Comment 13•8 years ago
|
||
backed out again for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=9526403&repo=fx-team
Flags: needinfo?(ejpbruel)
Comment 14•8 years ago
|
||
Backout: https://hg.mozilla.org/integration/fx-team/rev/2a2ce43bcafb
Updated•8 years ago
|
Iteration: 49.2 - May 23 → 49.3 - Jun 6
Comment 15•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e8f4f77bd99e
Assignee | ||
Comment 17•8 years ago
|
||
I fixed the test errors that were the cause for the last backout. Let's hope the patch sticks this time.
Flags: needinfo?(ejpbruel)
Comment 18•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9afab6308cd9
Assignee | ||
Updated•8 years ago
|
Updated•8 years ago
|
Whiteboard: [devtools-html]
Target Milestone: --- → Firefox 49
No longer depends on: 1327037
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•