Closed
Bug 1265723
Opened 8 years ago
Closed 8 years ago
Decouple fronts from actors in memory tool.
Categories
(DevTools :: Memory, defect, P1)
DevTools
Memory
Tracking
(firefox50 fixed)
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: ejpbruel, Assigned: fitzgen)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ejpbruel
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Assignee | ||
Updated•8 years ago
|
Priority: -- → P1
Updated•8 years ago
|
Whiteboard: [devtools-html]
The memory front is used in B2G production code, see bug 1265722 comment 15. Splitting its front into a new module and moving it to /devtools/client/fronts (as proposed in bug 1265722) would likely break B2G code. We can either make some build changes to accommodate or choose to ignore the issue since B2G is a tier 3 product.
Assignee | ||
Comment 2•8 years ago
|
||
Well, B2G isn;t tier 1, so I don't see the point in trying to bend over backwards for it.
(In reply to Nick Fitzgerald [:fitzgen] [⏰PDT; UTC-7] from comment #2) > Well, B2G isn;t tier 1, so I don't see the point in trying to bend over > backwards for it. Yes, fair enough. Just making sure the issue is known.
Updated•8 years ago
|
Assignee: nfitzgerald → nobody
Status: ASSIGNED → NEW
Flags: qe-verify-
Priority: P1 → P2
Assignee | ||
Comment 4•8 years ago
|
||
Needs bug 1265727 for the actorBridge variation that works with the shared specs.
Depends on: 1265727
Assignee | ||
Comment 5•8 years ago
|
||
Attachment #8761789 -
Flags: review?(ejpbruel)
Assignee | ||
Comment 6•8 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=53b0e1eb163e
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Updated•8 years ago
|
Iteration: --- → 50.1
Priority: P2 → P1
Reporter | ||
Updated•8 years ago
|
Attachment #8761789 -
Flags: review?(ejpbruel) → review+
Pushed by nfitzgerald@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/9545df18ca9e Decouple the MemoryFront from the MemoryActor; r=ejpbruel
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9545df18ca9e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Updated•8 years ago
|
Whiteboard: [devtools-html]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•