Closed
Bug 1265772
Opened 8 years ago
Closed 8 years ago
replace Services.console
Categories
(DevTools :: Framework, enhancement, P1)
DevTools
Framework
Tracking
(firefox49 fixed)
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
References
Details
(Whiteboard: [devtools-html])
Attachments
(1 file, 1 obsolete file)
Replace uses of Service.console as part of the de-chrome-ification project.
Assignee | ||
Updated•8 years ago
|
Summary: replace Service.console → replace Services.console
Assignee | ||
Comment 1•8 years ago
|
||
Of course I typod the name and it is "Services.console".
Updated•8 years ago
|
Severity: normal → enhancement
Whiteboard: [devtools-html]
Assignee | ||
Comment 2•8 years ago
|
||
MozReview-Commit-ID: Ax4EwhRVE0R This fixes uses of Services.console, with a few minor exceptions: * server/, of course * shared/webconsole, where some seem to be related to the actor; the code is a bit intermingled here * tests, but again as they are tests specifically for webconsole, maybe they can't be changed (I didn't look too deeply)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → ttromey
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/48567/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/48567/
Attachment #8744478 -
Flags: review?(bgrinstead)
Assignee | ||
Updated•8 years ago
|
Attachment #8743405 -
Attachment is obsolete: true
Assignee | ||
Comment 4•8 years ago
|
||
I forgot to note - this removes Console.jsm uses from most, but not all, spots. A few remain in other jsms, in loaders, and in tests.
Updated•8 years ago
|
Attachment #8744478 -
Flags: review?(bgrinstead) → review+
Comment 5•8 years ago
|
||
Comment on attachment 8744478 [details] MozReview Request: Bug 1265772 - don't use Services.console or Console.jsm in devtools; r?bgrins https://reviewboard.mozilla.org/r/48567/#review45593 Works for me, thanks
Assignee | ||
Comment 6•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0daa5d45611c
Assignee | ||
Comment 7•8 years ago
|
||
Something went wrong with that try run, but here's a better one: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ea2b37ea3c072008e24da0b4583126206f9814b
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Updated•8 years ago
|
Iteration: --- → 49.1 - May 9
Flags: qe-verify-
Priority: -- → P1
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c5c28bffad82
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•