Closed
Bug 1266294
Opened 9 years ago
Closed 9 years ago
Remove unnecessary compiler version checks for gcc <= 4.8.0 in mfbt
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla48
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Now that we require gcc >= 4.8.5, we can remove these compiler version checks for older gcc versions.
If bug 1243233 is reverted, then Linux mulet builds' gcc version requirement will drop from 4.9.3 to 4.7.3 and this bug's Endian.h change would need to be reverted.
Attachment #8743661 -
Flags: review?(nfroyd)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8743661 [details] [diff] [review]
remove-gcc-version-check.patch
Review of attachment 8743661 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for cleaning this up.
Attachment #8743661 -
Flags: review?(nfroyd) → review+
|
||
Comment 3•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in
before you can comment on or make changes to this bug.
Description
•