Closed
Bug 1266664
Opened 9 years ago
Closed 8 years ago
webgl-1.0.3 conformance failure texture-upload-size.html
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1286348
People
(Reporter: mtseng, Assigned: mtseng)
References
(Blocks 1 open bug, )
Details
(Whiteboard: webgl-conformance gfx-noted)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
There is an GL error when calling texSubImage2d. In release build, it causes fail. In debug build, it causes an assertion.
|
Assignee | |
Comment 1•9 years ago
|
||
ANGLE supports BGRA, so we might upload texture with internal format BGRA. But
the unpack format should remain RGBA; otherwise, later calling texSubImage2D with
unpack format RGBA would fail.
Attachment #8744215 -
Flags: review?(jgilbert)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8744215 [details] [diff] [review]
unpackFormat should be GL_RGBA.
Review of attachment 8744215 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/canvas/TexUnpackBlob.cpp
@@ +375,5 @@
> // RGB on the CPU. However, this is optimization is out-of-scope for now.
>
> static const webgl::DriverUnpackInfo kInfoBGRA = {
> LOCAL_GL_BGRA,
> + LOCAL_GL_RGBA,
This inverts the red and blue channels.
Attachment #8744215 -
Flags: review?(jgilbert) → review-
|
|
Assignee | |
Comment 3•9 years ago
|
||
Using a different approach. When upload surface, we cached internalFormat at
ImageInfo. So when calling texSubImage, we can use this cached value to
determine correct unpack format.
Attachment #8744830 -
Flags: review?(jgilbert)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8744215 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•8 years ago
|
||
I found that if I turn on layers.prefer-d3d9 then I could reproduce this issue. Do we care this?
Flags: needinfo?(mtseng) → needinfo?(jgilbert)
|
|
||
Comment 6•8 years ago
|
||
(In reply to Morris Tseng [:mtseng] [:Morris] from comment #5)
> I found that if I turn on layers.prefer-d3d9 then I could reproduce this
> issue. Do we care this?
Low priority, but feel free to take a look.
Flags: needinfo?(jgilbert)
|
|
Assignee | |
Comment 7•8 years ago
|
||
Looks like bug 1286348 fix this. Let dup this of bug 1286348.
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8744830 -
Flags: review?(jgilbert)
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•