Closed Bug 1266828 Opened 9 years ago Closed 9 years ago

turn ViewHelpers.jsm into a .js

Categories

(DevTools :: Framework, enhancement, P1)

Product:
DevTools
Component:
Framework
Type:
enhancement

Tracking

(firefox49 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 49
Iteration:
49.2 - May 23
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: tromey, Assigned: ochameau)

References

Details

(Whiteboard: [devtools-html])

Attachments

(1 file, 1 obsolete file)

patch v2
(deleted), patch
tromey
: review+
Details | Diff | Splinter Review
For the devtools de-chrome-ification project, we'll need to turn ViewHelpers.jsm into a .js. This may require some investigation; maybe it ought to be split up.
Flags: qe-verify-
Priority: -- → P2
Getting rid of jsm, something for me!
Assignee: nobody → poirot.alex
Attached patch patch v1 (obsolete) (deleted) — — Splinter Review
Blocks: devtools-html-1
No longer blocks: devtools-html-3
Status: NEW → ASSIGNED
Iteration: --- → 49.2 - May 23
Priority: P2 → P1
Attached patch patch v2 (deleted) — — Splinter Review
Fixes tests. Tom, In this patch, I only converted to a module. I haven't tried to split view-helpers. But it would be easy now that we have explicit require. We can easily grep for modules using X or Y exported method! So just tell me if we should pull out timeout/heritage.
Attachment #8752190 - Flags: review?(ttromey)
Attachment #8751663 - Attachment is obsolete: true
Comment on attachment 8752190 [details] [diff] [review] patch v2 Review of attachment 8752190 [details] [diff] [review]: ----------------------------------------------------------------- Thank you. Looks great.
Attachment #8752190 - Flags: review?(ttromey) → review+
(In reply to Alexandre Poirot [:ochameau] from comment #7) > So just tell me if we should pull out timeout/heritage. I think it's probably ok as-is. I saw in your patch that client code uses most (I think) parts of the file; my main concern was that maybe some bits wouldn't be usable on the client side. If we encounter problems we can always split it later if we need to.
https://hg.mozilla.org/mozilla-central/rev/f10ea2e1322b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Iteration: 49.3 - Jun 6 → 49.2 - May 23
Iteration: 49.2 - May 23 → 49.3 - Jun 6
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: