Tom Tromey :tromey Assignee
	Description • 8 years ago

devtools/shared/inspector/css-logic.js uses a number of chrome APIs.
However, it's unclear which parts of this run on the client.
So, we need to investigate that before taking action.

	Tom Tromey :tromey Assignee
	Comment 1 • 8 years ago

Some of it is dead code as well:
https://bugzilla.mozilla.org/show_bug.cgi?id=1225254

	Tom Tromey :tromey Assignee
	Comment 2 • 8 years ago

I think the route forward here is in three parts:
1. Delete dead code; bug 1225254
2. Split css-logic so that the server-only bits are in devtools/server
3. De-chrome the remaining code

I plan to do #2 and #3 here.

	Tom Tromey :tromey Assignee
	Comment 3 • 8 years ago

Also I should note that I plan to skip the l10n bits as those are being handled
in another bug.

	Tom Tromey :tromey Assignee
	Comment 4 • 8 years ago

Also leaving the nsIXULRuntime bit for the same reason.

	Tom Tromey :tromey Assignee
	Comment 5 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/60574/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60574/

	Patrick Brosset <:pbro>
	Comment 6 • 8 years ago

Comment on attachment 8765026 [details]
Bug 1266844 - use URL, not nsIURL, in css-logic.js;

https://reviewboard.mozilla.org/r/60574/#review57858

So, `URL` is available as a global in our modules? That's nice.
Maybe we should think of creating some doc on the wiki about the environment available in modules, depending on how they were loaded, and sending an email to the mailing list about it.

	Tom Tromey :tromey Assignee
	Comment 7 • 8 years ago

(In reply to Patrick Brosset <:pbro> from comment #6)
> Comment on attachment 8765026 [details]
> Bug 1266844 - use URL, not nsIURL, in css-logic.js;
> 
> https://reviewboard.mozilla.org/r/60574/#review57858
> 
> So, `URL` is available as a global in our modules? That's nice.

Yeah, since bug 1265813

> Maybe we should think of creating some doc on the wiki about the environment
> available in modules, depending on how they were loaded, and sending an
> email to the mailing list about it.

Good idea.

	Tom Tromey :tromey Assignee
	Comment 8 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3c13395a6eee

	Tom Tromey :tromey Assignee
	Comment 9 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc75ce6c3fc3f3820b36726ea62d140c91898327

	Tom Tromey :tromey Assignee
	Comment 10 • 8 years ago

(In reply to Patrick Brosset <:pbro> from comment #6)

> Maybe we should think of creating some doc on the wiki about the environment
> available in modules, depending on how they were loaded, and sending an
> email to the mailing list about it.

Now bug 1283523

	Pulsebot
	Comment 11 • 8 years ago

Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/c6ce12a74300
use URL, not nsIURL, in css-logic.js; r=pbro

	Carsten Book [:Tomcat]
	Comment 12 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/c6ce12a74300