This is just a port of the existing stub. I think with the IR it'd be easy now to also handle properties on the proto's prototype (Object.prototype), but we can do that later. 7 files changed, 99 insertions(+), 202 deletions(-)

Comment on attachment 8744841 [details] [diff] [review] Patch Review of attachment 8744841 [details] [diff] [review]: ----------------------------------------------------------------- It strikes me that we should have a commented list of what IR ops already exist, so that people adding new stuff later don't feel compelled to re-invent the wheel. ::: js/src/jit/CacheIR.cpp @@ +72,3 @@ > } > > + if (!emitted_ && !tryAttachPrimitive(*writer, valId)) Is this better than else { }? Either way is fine.

I should just land this.

Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/71808c547e9c Port primitive value getprop stub to CacheIR. r=efaust

Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c64ed9250f55 followup - Use static_assert instead of MOZ_ASSERT. r=red, CLOSED TREE

https://hg.mozilla.org/mozilla-central/rev/71808c547e9c https://hg.mozilla.org/mozilla-central/rev/c64ed9250f55