Closed
Bug 1267296
Opened 9 years ago
Closed 9 years ago
Bug 1248708 broke compilation with Visual Studio 2013 [nsCSSParser.cpp(10816) : error C2057: expected constant expression]
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
DUPLICATE
of bug 1248708
People
(Reporter: philip.chee, Unassigned)
Details
This broke compilation with VS2013:
c:/t1/hg/comm-central/mozilla/layout/style/nsCSSParser.cpp(10816) : error C2057: expected constant expression
c:/t1/hg/comm-central/mozilla/layout/style/nsCSSParser.cpp(10816) : error C2466: cannot allocate an array of constant size 0
c:/t1/hg/comm-central/mozilla/layout/style/nsCSSParser.cpp(10816) : error C2133: 'values' : unknown size
Comment 1•9 years ago
|
||
Our current situation that VS2013 is still officially supported but isn't run in our infra is really unhelpful... I really think we should have a server runs that to at least confirm the code still builds, or alternatively we should just drop it and require VS2015 to build new code...
Comment 2•9 years ago
|
||
The followup that I just pushed (bug 1248708 comment 99) should fix this.
So, we should probably just dupe this back over to that bug (or, resolve as you see fit).
Flags: needinfo?(philip.chee)
Reporter | ||
Comment 3•9 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #2)
> The followup that I just pushed (bug 1248708 comment 99) should fix this.
>
> So, we should probably just dupe this back over to that bug (or, resolve as
> you see fit).
I'll DUP this back. Thanks. Should have remembered MOZ_ARRAY_LENGTH myself.
Status: NEW → RESOLVED
Closed: 9 years ago
No longer depends on: 1248708
Flags: needinfo?(philip.chee)
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•