Closed
Bug 1267884
Opened 8 years ago
Closed 8 years ago
Update support libraries to 23.4
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(firefox52 fixed)
RESOLVED
FIXED
Firefox 52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: liuche, Assigned: ahunt)
References
Details
(Whiteboard: [MobileAS])
Attachments
(4 files, 4 obsolete files)
The 23.2.1 recyclerview compat library fixes a bug where wrap_content didn't work, and recyclerview expands to fill the whole space. We need this for our new empty view for the Combined History home panel, so that we can have the empty view displayed underneath the recycler view. Note to self, this requires: * Update dependency in build.gradle * Build artifact with a gradle-dependencies try push * Push new artifact changes to tooltool and update the in-tree manifests https://gecko.readthedocs.org/en/latest/build/buildsystem/toolchains.html#firefox-for-android-with-gradle
Reporter | ||
Comment 1•8 years ago
|
||
Er, I guess it was not a bug, just a new feature: http://android-developers.blogspot.com/2016/02/android-support-library-232.html
Comment 2•8 years ago
|
||
We should update all support libraries to 23.2.1. They all need to be in sync to work properly. After that we should do some testing, I saw a bunch of support library bug reports and it looked like you are trading bugfixes against new bugs with every update currently. :) I'm just updating Gradle and the gradle plugin as part of bug 1263390. To do so I need to touch all the same parts (build.gradle, tooltool, ...). I could update the support libraries as part of bug 1263390 too.
Comment 3•8 years ago
|
||
I just saw that there is already version 23.3 out. I'm having so much fun updating the builder that I'll take this too.. ;)
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Summary: Update recyclerview compat library from 23.0.1 to 23.2.1 → Update support libraries to 23.3
Comment 9•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/51967/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/51967/
Attachment #8751339 -
Flags: review?(liuche)
Attachment #8751340 -
Flags: review?(liuche)
Attachment #8751341 -
Flags: review?(liuche)
Comment 10•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/51969/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/51969/
Comment 11•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/51971/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/51971/
Comment 12•8 years ago
|
||
This adds the new libraries and builds locally and on the builders. However our settings activity is crashing because we somehow reference VectorDrawableCompat which has been removed.
Comment 13•8 years ago
|
||
appcompat has new dependencies: support-vector-drawable and animated-vector-drawable. I tried to add them but this crash is still there. Either I did something wrong or those libraries are somewhat special. It's also notable that this crash only happens when building with 'mach'. Gradle builds just work.
Comment 14•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/51983/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/51983/
Comment 15•8 years ago
|
||
Leaving this for a rainy day..
Assignee: s.kaspari → nobody
Status: ASSIGNED → NEW
Updated•8 years ago
|
Attachment #8751339 -
Flags: review?(liuche)
Updated•8 years ago
|
Attachment #8751340 -
Flags: review?(liuche)
Updated•8 years ago
|
Attachment #8751341 -
Flags: review?(liuche)
Comment 16•8 years ago
|
||
23.4 has been released yesterday.
Summary: Update support libraries to 23.3 → Update support libraries to 23.4
Assignee | ||
Comment 17•8 years ago
|
||
I've started looking into this. The "Add new support library dependencies: support-vector-drawable, animated-vector-drawable." patch seems to be enough for my mach builds to not crash in the settings activity (after clobbering). We'll need to reduce our method count slightly for this to be able to land, I'm looking into that in Bug 1306104 right now.
Assignee | ||
Updated•8 years ago
|
Priority: -- → P1
Assignee | ||
Updated•8 years ago
|
Priority: P1 → P2
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 21•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=02e078c3e681
Assignee | ||
Updated•8 years ago
|
Attachment #8796603 -
Flags: review?(liuche) → review?(s.kaspari)
Updated•8 years ago
|
Attachment #8751339 -
Attachment is obsolete: true
Updated•8 years ago
|
Attachment #8751340 -
Attachment is obsolete: true
Updated•8 years ago
|
Attachment #8751341 -
Attachment is obsolete: true
Updated•8 years ago
|
Attachment #8751369 -
Attachment is obsolete: true
Comment 22•8 years ago
|
||
mozreview-review |
Comment on attachment 8796601 [details] Bug 1267884 - Upgrade support libraries to 23.4 https://reviewboard.mozilla.org/r/82404/#review81038
Attachment #8796601 -
Flags: review?(s.kaspari) → review+
Comment 23•8 years ago
|
||
mozreview-review |
Comment on attachment 8796602 [details] Bug 1267884 - Add empty updateVisuals() to GeckoCustomTabsService to match customtabs-23.4 https://reviewboard.mozilla.org/r/82406/#review81040
Attachment #8796602 -
Flags: review?(s.kaspari) → review+
Comment 24•8 years ago
|
||
mozreview-review |
Comment on attachment 8796603 [details] Bug 1267884 - Touch CLOBBER file. https://reviewboard.mozilla.org/r/82408/#review81042
Attachment #8796603 -
Flags: review?(s.kaspari) → review+
Assignee | ||
Comment 25•8 years ago
|
||
Sorry for the priority spamming, I thought this wouldn't be ready today - but it looks like it will make it after all.
Priority: P2 → P1
Comment 26•8 years ago
|
||
Pushed by ahunt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/25e1ca942799 Upgrade support libraries to 23.4 r=sebastian https://hg.mozilla.org/integration/autoland/rev/abc52d4c5f87 Add empty updateVisuals() to GeckoCustomTabsService to match customtabs-23.4 r=sebastian https://hg.mozilla.org/integration/autoland/rev/cc4bdd6afea0 Touch CLOBBER file. r=sebastian
Comment 27•8 years ago
|
||
Backout by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/537a4ce2ecb3 Backed out changesets cc4bdd6afea0, abc52d4c5f87, and 25e1ca942799 for Android bustage
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 32•8 years ago
|
||
mozreview-review |
Comment on attachment 8797181 [details] Bug 1267884 - Update TestColorProcessor to reflect update palette library colour extraction https://reviewboard.mozilla.org/r/82774/#review81706 ::: mobile/android/tests/background/junit4/src/org/mozilla/gecko/icons/processing/TestColorProcessor.java:36 (Diff revision 1) > > final Processor processor = new ColorProcessor(); > processor.process(null, response); > > Assert.assertTrue(response.hasColor()); > - Assert.assertEquals(0xFFF80000, response.getColor()); > + Assert.assertEquals(0xFFFF0000, response.getColor()); nit: Maybe use Color.RED like we use below to generate the image.
Attachment #8797181 -
Flags: review?(s.kaspari) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 37•8 years ago
|
||
Pushed by ahunt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6ac1eb24f8ab Upgrade support libraries to 23.4 r=sebastian https://hg.mozilla.org/integration/autoland/rev/982c7d7ce6f0 Add empty updateVisuals() to GeckoCustomTabsService to match customtabs-23.4 r=sebastian https://hg.mozilla.org/integration/autoland/rev/37bb8e6b60e2 Touch CLOBBER file. r=sebastian https://hg.mozilla.org/integration/autoland/rev/579fbfb0801a Update TestColorProcessor to reflect update palette library colour extraction r=sebastian
Comment 38•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6ac1eb24f8ab https://hg.mozilla.org/mozilla-central/rev/982c7d7ce6f0 https://hg.mozilla.org/mozilla-central/rev/37bb8e6b60e2 https://hg.mozilla.org/mozilla-central/rev/579fbfb0801a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Comment 39•8 years ago
|
||
This has increased the classes.dex size by 230kB, I assume there is nothing we can do to reduce this?
Updated•8 years ago
|
status-firefox49:
affected → ---
Updated•8 years ago
|
Iteration: --- → 1.6
Updated•8 years ago
|
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•