Closed
Bug 1268432
Opened 9 years ago
Closed 9 years ago
B2GOS: Followup for Bug 1266595 - Replace Task with Runnable, CancelableTask with CancelableRunnable
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(firefox49 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: gwagner, Assigned: tzimmermann)
References
Details
Attachments
(1 file)
(deleted),
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
../../../../workspace/gecko/ipc/netd/Netd.h:41:1: error: expected class-name before '{' token
../../../../workspace/gecko/ipc/netd/Netd.cpp:220:23: error: 'FROM_HERE' was not declared in this scope
../../../../workspace/gecko/ipc/netd/Netd.cpp:337:5: error: 'FROM_HERE' was not declared in this scope
../../../../workspace/gecko/ipc/netd/Netd.cpp:350:5: error: 'FROM_HERE' was not declared in this scope
Reporter | ||
Updated•9 years ago
|
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → tzimmermann
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8747113 -
Flags: review?(khuey)
Comment on attachment 8747113 [details] [diff] [review]
[01] Bug 1268432: Replace |Task| with |Runnable| in B2G code
If there's something small and specific you want me to look at I can, but otherwise I don't have time to review code for dead products.
Attachment #8747113 -
Flags: review?(khuey)
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #2)
> Comment on attachment 8747113 [details] [diff] [review]
> [01] Bug 1268432: Replace |Task| with |Runnable| in B2G code
>
> If there's something small and specific you want me to look at I can, but
> otherwise I don't have time to review code for dead products.
It's not dead yet. We still have a final release to ship and hand it over to others. And this patch will have to be part of it.
Assignee | ||
Updated•9 years ago
|
Attachment #8747113 -
Flags: review?(khuey)
Assignee | ||
Updated•9 years ago
|
Attachment #8747113 -
Flags: review?(khuey) → review?(fabrice)
Updated•9 years ago
|
Attachment #8747113 -
Flags: review?(fabrice) → review+
Comment 5•9 years ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•