Eddy Bruel [:ejpbruel] Assignee
	Description • 8 years ago

The inspector actor depends on the highlighter actors, so the latter have to be decoupled before the former.

	Eddy Bruel [:ejpbruel] Assignee
	Comment 1 • 8 years ago

Carrying over r+ from jryans in bug 1265722.

	Eddy Bruel [:ejpbruel] Assignee
	Comment 2 • 8 years ago

Carrying over r+ from jryans in bug 1265722.

	Eddy Bruel [:ejpbruel] Assignee
	Comment 3 • 8 years ago

I had to manually rebase these patches, so I'd like you to take another pass at them. Should just be a rubber stamp review.

	Eddy Bruel [:ejpbruel] Assignee
	Comment 4 • 8 years ago

Ditto for this patch.

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)
	Comment 5 • 8 years ago

Comment on attachment 8747732 [details] [diff] [review]
Decouple HighlighterFront from HighlighterActor.

Review of attachment 8747732 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/shared/specs/highlighters.js
@@ +6,5 @@
> +const {
> +  Arg,
> +  Option,
> +  generateActorSpec
> +} = require("devtools/server/protocol.js");

Just noticed you have added the ".js" extension in `require` in most of your patches...  It's optional, and we typically omit it, so let's remove it everywhere that you have added it.

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)
	Comment 6 • 8 years ago

Comment on attachment 8747733 [details] [diff] [review]
Decouple CustomHighlighterFront from CustomHighlighterActor.

Review of attachment 8747733 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/fronts/highlighters.js
@@ +19,5 @@
>  });
>  
>  exports.HighlighterFront = HighlighterFront;
> +
> +const CustomHighlighterFront = FrontClassWithSpec(customHighlighterSpec, {});

Is it possible to drop the second arg if it's empty?

	Eddy Bruel [:ejpbruel] Assignee
	Comment 7 • 8 years ago

Try push for the patch to decouple HighlighterFront from HighlighterActor:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d0f55d79d7b

	Pulsebot
	Comment 8 • 8 years ago

https://hg.mozilla.org/integration/fx-team/rev/b041ad17b6c8

	Eddy Bruel [:ejpbruel] Assignee
	Comment 9 • 8 years ago

Try push for the patch to decouple CustomHighlighterFront from CustomHighlighterActor:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd1e03a837e6

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 10 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/b041ad17b6c8

	Pulsebot
	Comment 11 • 8 years ago

https://hg.mozilla.org/integration/fx-team/rev/52f40a1102ad

	Carsten Book [:Tomcat]
	Comment 12 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/52f40a1102ad