Closed
Bug 1268471
Opened 8 years ago
Closed 8 years ago
Multiple calls of NativeWindow.doorhanger.show dismisses the domain
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox49 fixed)
RESOLVED
FIXED
Firefox 49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: esawin, Assigned: esawin)
Details
Attachments
(2 files)
(deleted),
patch
|
liuche
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
esawin
:
review+
|
Details | Diff | Splinter Review |
Multiple calls (e.g., triggered by a timeout-based recursion) of NativeWindow.doorhanger.show with unchanged value and tab ID without user interaction cause an issue with the doorhanger content, it no longer contains the domain name after the first show.
Always calling NativeWindow.doorhanger.hide on the value/tab ID pair before calling show is a possible workaround.
Assignee | ||
Comment 2•8 years ago
|
||
addDoorHanger removes (removeDoorHanger) the existing doorhanger without dismissing it. The finalizing call to updatePopup then returns early because the doorhanger is still showing (isShowing) so we miss to add the title.
We have either have to dismiss the old duplicate doorhanger on removal or we have to add the title disregarding the isShowing state. Since redundant calls to showTitle on the same instance don't seem to have any side effects, I've implemented the latter solution with this patch.
Flags: needinfo?(liuche)
Attachment #8748471 -
Flags: review?(liuche)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → esawin
Updated•8 years ago
|
Attachment #8748471 -
Flags: review?(liuche) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Since bug 1243431 has already landed, I'm removing the workaround used there with this patch. r=me for trivial change.
Attachment #8750284 -
Flags: review+
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8516745ca5af
https://hg.mozilla.org/mozilla-central/rev/90e58b8e1443
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•