During investigation of some tab-panel textbox focusing issues related to bug 103197 (and the various bugs it blocks), we (Jag and I) decided to apply a comprehensive fix to all <dialog>s by doing the focus initializatio logic via a setTimeout. This seems to fix the problem when it appears in a <dialog>. It does not fix the problem when it occurs in <window>s, such as the Address Book New Card window. Patch forthcoming. Jag has reviewed and we will be asking Joe Hewitt to sr= it. We've tested this with a smattering of dialogs (text zoom, preferences, composer table dialog, new page setup dialog, etc.) and no regressions were evident.

Nominating; this is necessary to land the updated page setup dialog. It may fix other dialog focusing problems elsewhere.

Comment on attachment 70628 [details] [diff] [review] Fix, v1.0 sr=jag if you remove the postLoadInitFocus method :-)

nsbeta1+ per Nav triage team

Yes! I knew it would be better to fix this for everyone in XBL.

Of course, this doesn't fix those people who haven't converted their dialogs to the <dialog> tag yet.

Comment on attachment 70631 [details] [diff] [review] patch, v2.0 (without the extraneous stuff) sr=hewitt

Comment on attachment 70631 [details] [diff] [review] patch, v2.0 (without the extraneous stuff) r=jag

Comment on attachment 70631 [details] [diff] [review] patch, v2.0 (without the extraneous stuff) a=asa (on behalf of drivers) for checkin to 0.9.9

fix checked in

FYI: This is a good thing to do, but it does not fix the basic problem in bug 103197. Alas, individual dialogs that set focus to a particular element still need to also use "setTimeout". Interestingly, the setTimeout hack we added for Composer dialogs stopped working in the past few days, but the fix for this bug has now cured that!