Eddy Bruel [:ejpbruel] Assignee
	Description • 8 years ago

The inspector actor depends on the style actors, so the latter have to be decoupled before the former.

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)
	Comment 3 • 8 years ago

Comment on attachment 8747727 [details] [diff] [review]
Decouple PageStyleFront form PageStyleActor.

Review of attachment 8747727 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/fronts/styles.js
@@ +10,5 @@
> +  custom
> +} = require("devtools/server/protocol.js");
> +const { pageStyleSpec } = require("devtools/shared/specs/styles.js");
> +
> +Cu.import("resource://gre/modules/Task.jsm");

Use the form `const { Task } = require("resource://gre/modules/Task.jsm");` which is easier to lint.

	J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)
	Comment 4 • 8 years ago

Comment on attachment 8747728 [details] [diff] [review]
Decouple StyleRuleFront and StyleRuleActor.

Review of attachment 8747728 [details] [diff] [review]:
-----------------------------------------------------------------

This seems like the wrong patch, it's changing highlighters.js.

	Eddy Bruel [:ejpbruel] Assignee
	Comment 5 • 8 years ago

Try push for the patch to decouple PageStyleFront from PageStyleActor:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=940c645563cc

	Eddy Bruel [:ejpbruel] Assignee
	Comment 6 • 8 years ago

Now with the correct patch.

	Eddy Bruel [:ejpbruel] Assignee
	Comment 7 • 8 years ago

Try push for the patch to decouple StyleRuleFront from StyleRuleActor:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8051feb3d098

	Eddy Bruel [:ejpbruel] Assignee
	Comment 8 • 8 years ago

The try push for the patch to decouple StyleRuleFront from StyleRuleActor had test failures due to missing dependencies. Here's a new try push with that issue addressed:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=99f983bc6b80

	Pulsebot
	Comment 9 • 8 years ago

https://hg.mozilla.org/integration/fx-team/rev/27bbfef7a520

	Pulsebot
	Comment 10 • 8 years ago

https://hg.mozilla.org/integration/fx-team/rev/da2b27e1aabd

	Carsten Book [:Tomcat]
	Comment 11 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/27bbfef7a520
https://hg.mozilla.org/mozilla-central/rev/da2b27e1aabd

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]
	Comment 12 • 8 years ago

Was this bug supposed to take care of the StyleEditorActor too? Or is that a different bug? Or do we need a bug?

	Eddy Bruel [:ejpbruel] Assignee
	Comment 13 • 8 years ago

Bug 1265730 took care of the StyleEditorActor.