+++ This bug was initially created as a clone of Bug #1265738 +++ Changes since last update: #7219 Convert the password prompt to a class #7233 Adjust incorrect first obj number of "free" xref entry in `XRef_readXRefTable` (issue 7229) #7209 Moves all document.getElementById lookups into viewer.js #7235 Version 1.5 #7236 Release of 1.5.188 #7237 Prevent accidentally overriding the `error` function in the `commonobj` messageHandler in api.js (issue 7232) #7130 Add element to text layer even if width === 0 #7241 Makes importl10n and server async gulp functions. #7202 Refactors dependencies of PDFViewerApplication on external services #7240 Moves bundle target/task to gulpfile.js #7251 Makes defines parameter non-optional in createBundle. #7255 Mention web application usage in README.md #7256 Port the `publish` target to Gulp #7262 Fixes weird loop in the bidi.js. #7254 Introducing EventBus for the viewer UI. #7268 Better components examples.

Backed out for browser_pdfjs_navigation.js failures. https://hg.mozilla.org/integration/fx-team/rev/0e049ed70920 https://treeherder.mozilla.org/logviewer.html#?job_id=9062603&repo=fx-team 17:34:54 INFO - 293 INFO checking window state 17:34:54 INFO - 294 INFO Entering test bound test 17:34:54 INFO - 295 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | pdf handler defaults to always-ask is false - 17:34:54 INFO - 296 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | pdf handler defaults to internal - 17:34:54 INFO - 297 INFO Pref action: 3 17:34:54 INFO - 298 INFO Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element 'selection'. Ruleset ignored due to bad selector." {file: "resource://pdf.js/web/viewer.css" line: 60 column: 13 source: ".textLayer ::selection { background: rgb(0,0,255); }"}] 17:34:54 INFO - 299 INFO Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element 'selection'. Ruleset ignored due to bad selector." {file: "resource://pdf.js/web/viewer.css" line: 1405 column: 2 source: "::selection { background: rgba(0,0,255,0.3); }"}] 17:34:54 INFO - 300 INFO Console message: [JavaScript Warning: "Prefixed Fullscreen API is deprecated. Please use unprefixed API for fullscreen. For more help https://developer.mozilla.org/en-US/docs/Web/API/Fullscreen_API" {file: "resource://pdf.js/web/viewer.js" line: 7179}] 17:34:54 INFO - 301 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | document content has viewer UI - {} == true - 17:34:54 INFO - 302 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | window content has PDFJS object - true == true - 17:34:54 INFO - 303 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | Element 'button#next' has been found - {} == true - 17:34:54 INFO - 304 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | navigated to next page using NEXT button - 2 == 2 - 17:34:54 INFO - 305 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | Element 'button#previous' has been found - {} == true - 17:34:54 INFO - 306 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | navigated to previous page using PREV button - 1 == 1 - 17:34:54 INFO - 307 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | Element 'button#next' has been found - {} == true - 17:34:54 INFO - 308 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | navigated to next page using NEXT button - 2 == 2 - 17:34:54 INFO - 309 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | Element 'input#pageNumber' has been found - {} == true - 17:34:54 INFO - 310 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | navigated to first page using pagenumber - 1 == 1 - 17:34:54 INFO - 311 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | Element '#thumbnailView a:nth-child(4)' has been found - {} == true - 17:34:54 INFO - 312 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | navigated to 4th page using thumbnail view - 4 == 4 - 17:34:54 INFO - 313 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | Element '#thumbnailView a:nth-child(2)' has been found - {} == true - 17:34:54 INFO - 314 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | navigated to 2nd page using thumbnail view - 2 == 2 - 17:34:54 INFO - 315 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | Element '#viewer' has been found - {} == true - 17:34:54 INFO - 316 INFO Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key="c" modifiers="accel,alt"" {file: "chrome://mochikit/content/tests/BrowserTestUtils/content-task.js line 52 > eval" line: 39}] 17:34:54 INFO - 317 INFO Console message: [JavaScript Warning: "Key event not available on some keyboard layouts: key="i" modifiers="accel,alt,shift"" {file: "chrome://mochikit/content/tests/BrowserTestUtils/content-task.js line 52 > eval" line: 39}] 17:34:54 INFO - 318 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | navigated to 1st page using 'home' key - 1 == 1 - 17:34:54 INFO - 319 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | Element '#viewer' has been found - {} == true - 17:34:54 INFO - 320 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | navigated to 2nd page using 'Page Down' key - 2 == 2 - 17:34:54 INFO - 321 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | Element '#viewer' has been found - {} == true - 17:34:54 INFO - 322 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | navigated to 1st page using 'Page Up' key - 1 == 1 - 17:34:54 INFO - 323 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | Element '#viewer' has been found - {} == true - 17:34:54 INFO - 324 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | navigated to 2nd page using 'right' key - 2 == 2 - 17:34:54 INFO - 325 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | Element '#viewer' has been found - {} == true - 17:34:54 INFO - 326 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | navigated to 1st page using 'left' key - 1 == 1 - 17:34:54 INFO - 327 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | Element '#viewer' has been found - {} == true - 17:34:54 INFO - 328 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | navigated to last page using 'home' key - 5 == 5 - 17:34:54 INFO - 329 INFO TEST-PASS | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | Element '.outlineItem:nth-child(1) a' has been found - {} == true - 17:34:54 INFO - 330 INFO TEST-UNEXPECTED-FAIL | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | A promise chain failed to handle a rejection: - at chrome://mochikit/content/tests/BrowserTestUtils/content-task.js:62 - TypeError: e is undefined 17:34:54 INFO - Stack trace: 17:34:54 INFO - @chrome://mochikit/content/tests/BrowserTestUtils/content-task.js:62:9 17:34:54 INFO - Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:940:21 17:34:54 INFO - this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7 17:34:54 INFO - Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11 17:34:54 INFO - this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:779:7 17:34:54 INFO - this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:714:7 17:34:54 INFO - TaskImpl_handleException@resource://gre/modules/Task.jsm:455:5 17:34:54 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:331:11 17:34:54 INFO - promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:395:7 17:34:54 INFO - promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:395:7 17:34:54 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:327:13 17:34:54 INFO - promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:395:7 17:34:54 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:327:13 17:34:54 INFO - promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:395:7 17:34:54 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:327:13 17:34:54 INFO - promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:395:7 17:34:54 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:327:13 17:34:54 INFO - promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:395:7 17:34:54 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:327:13 17:34:54 INFO - promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:395:7 17:34:54 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:327:13 17:34:54 INFO - promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:395:7 17:34:54 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:327:13 17:34:54 INFO - promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:395:7 17:34:54 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:327:13 17:34:54 INFO - promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:395:7 17:34:54 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:327:13 17:34:54 INFO - promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:395:7 17:34:54 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:327:13 17:34:54 INFO - promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:395:7 17:34:54 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:327:13 17:34:54 INFO - promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:395:7 17:34:54 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:327:13 17:34:54 INFO - TaskImpl@resource://gre/modules/Task.jsm:280:3 17:34:54 INFO - createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:254:14 17:34:54 INFO - Task_spawn@resource://gre/modules/Task.jsm:168:12 17:34:54 INFO - @chrome://mochikit/content/tests/BrowserTestUtils/content-task.js:54:5 17:35:21 INFO - 331 INFO Longer timeout required, waiting longer... Remaining timeouts: 1 17:35:29 INFO - 332 INFO Console message: [JavaScript Error: "1461890129239 Toolkit.GMP ERROR GMPInstallManager.simpleCheckAndInstall Could not check for addons: Error: got node name: html, expected: updates (resource://gre/modules/addons/ProductAddonChecker.jsm:153:11) JS Stack trace: parseXML@ProductAddonChecker.jsm:153:11 < promise callback*ProductAddonChecker.getProductAddonList@ProductAddonChecker.jsm:320:12 < GMPInstallManager.prototype.checkForAddons@GMPInstallManager.jsm:107:5 < GMPInstallManager.prototype.simpleCheckAndInstall<@GMPInstallManager.jsm:204:29 < gBrowserInit._delayedStartup/<@browser.js:1326:7 < setTimeout handler*gBrowserInit._delayedStartup@browser.js:1322:5 < EventListener.handleEvent*gBrowserInit.onLoad@browser.js:1028:5 < onload@browser.xul:1:1" {file: "resource://gre/modules/Log.jsm" line: 753}] 17:35:29 INFO - App_append@resource://gre/modules/Log.jsm:753:9 17:35:29 INFO - Logger.prototype.log@resource://gre/modules/Log.jsm:389:7 17:35:29 INFO - LoggerRepository.prototype.getLoggerWithMessagePrefix/proxy.log@resource://gre/modules/Log.jsm:504:44 17:35:29 INFO - Logger.prototype.error@resource://gre/modules/Log.jsm:397:5 17:35:29 INFO - GMPInstallManager.prototype.simpleCheckAndInstall<@resource://gre/modules/GMPInstallManager.jsm:285:7 17:35:29 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:320:40 17:35:29 INFO - Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:940:21 17:35:29 INFO - this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7 17:35:29 INFO - Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11 17:35:29 INFO - this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:779:7 17:35:29 INFO - this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:714:7 17:35:29 INFO - GMPInstallManager.prototype.checkForAddons/<@resource://gre/modules/GMPInstallManager.jsm:116:7 17:35:29 INFO - promise callback*GMPInstallManager.prototype.checkForAddons@resource://gre/modules/GMPInstallManager.jsm:107:5 17:35:29 INFO - GMPInstallManager.prototype.simpleCheckAndInstall<@resource://gre/modules/GMPInstallManager.jsm:204:29 17:35:29 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:319:40 17:35:29 INFO - TaskImpl@resource://gre/modules/Task.jsm:280:3 17:35:29 INFO - createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:254:14 17:35:29 INFO - gBrowserInit._delayedStartup/<@chrome://browser/content/browser.js:1326:7 17:35:29 INFO - setTimeout handler*gBrowserInit._delayedStartup@chrome://browser/content/browser.js:1322:5 17:35:29 INFO - EventListener.handleEvent*gBrowserInit.onLoad@chrome://browser/content/browser.js:1028:5 17:35:29 INFO - onload@chrome://browser/content/browser.xul:1:1 17:36:06 INFO - Not taking screenshot here: see the one that was previously logged 17:36:06 INFO - 333 INFO TEST-UNEXPECTED-FAIL | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | Test timed out - 17:36:06 INFO - MEMORY STAT | vsize 793MB | residentFast 212MB | heapAllocated 92MB 17:36:06 INFO - 334 INFO TEST-OK | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | took 90170ms 17:36:06 INFO - Not taking screenshot here: see the one that was previously logged 17:36:06 INFO - 335 INFO TEST-UNEXPECTED-FAIL | browser/extensions/pdfjs/test/browser_pdfjs_navigation.js | Found a tab after previous test timed out: http://example.com/browser/browser/extensions/pdfjs/test/file_pdfjs_test.pdf -

I'm wondering if the test failures are from #7209.

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3) > I'm wondering if the test failures are from #7209. ... or #7254 -- I'll investigate.

We are using the UI to pull page number, which depends on when 'pagechange' event is fired before or after control change. There are better ways to find out the current page number (e.g. via event object). I created https://github.com/mozilla/pdf.js/pull/7272 to simulate the old way.

Thanks for the quick fix, Yury! Changes since last update: #7266 Removes circular dependency of secondary toolbar on app.js. #7272 Adds post UI control change events.

Might as well pick up the warning fix while I'm at it. #7273 Prevent "Prefixed Fullscreen API is deprecated." warnings in the MOZCENTRAL version (issue 7270)