Closed Bug 1268711 Opened 9 years ago Closed 9 years ago

crashes generated by ContentParent::KillHard (e.g., for ShutDownKill) are not clearly distinguished from other crashes

Categories

(Socorro :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1269817

People

(Reporter: dbaron, Unassigned)

Details

There's code in ContentParent::KillHard, added in: https://hg.mozilla.org/mozilla-central/rev/20c494ff9887 and modified in interesting ways in: https://hg.mozilla.org/mozilla-central/rev/5fc092347f17 https://hg.mozilla.org/mozilla-central/rev/ce6dbefadccd that kills the child process and sends a crash report for it. One of the cases where it does this is the ShutDownKill case, which happens when we've asked the child process to shut down, but it doesn't do so in an appropriate amount of time. These crash reports show up in https://crash-stats.mozilla.com/ with signatures that look like other crashes. This can be very confusing, especially when there are actual crashes in the same function. (In general, the signatures aren't nearly as useful for process kills that happen when code is running (as opposed to a process that's deadlocked), because a running process moves quickly between large numbers of functions.) Therefore, I think these crashes should be prefixed with something like the "hang |" that we use for plugin hangs or the "shutdownhang |" that we use for browser shutdown hangs. Perhaps "kill |", although I'm not particularly attached to it? For example, bp-555441c4-7e4d-4e70-919d-ad3752160428 is one of these ShutDownKill crashes, but all of the other crashes with that signature are not; these are clearly different bugs, but it leads to confusion like that in bug 1022677. I'm not quite sure whether any changes would need to happen on the client side to cause this, or whether it would all be done in Socorro. ted points to: https://github.com/mozilla/socorro/blob/b9c5bfcae8bfb8d0b56332c60ff6c711e6b45eba/socorro/processor/signature_utilities.py#L252 https://github.com/mozilla/socorro/blob/426eefc3072c1d86599d296ffd5a51767e4328f4/socorro/processor/hybrid_processor.py#L714 but can hopefully fill in something more useful here. :-)
Flags: needinfo?(ted)
Maybe "ipc |" when ipc_channel_error exists. Maybe "ipc | ShutDownKill |" for it being this string. Handy viewer lost in an old bug thread; https://bsmedberg.github.io/socorro-toolbox/html/multiple-minidumps.html
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Flags: needinfo?(ted)
You need to log in before you can comment on or make changes to this bug.