Closed Bug 1268719 Opened 9 years ago Closed 8 years ago

Very large allocations in refill_callback_duplex

Categories

(Core :: Audio/Video: cubeb, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox49 --- fixed

People

(Reporter: mccr8, Assigned: padenot)

References

Details

(Keywords: crash, regression, steps-wanted)

Crash Data

I see a number of these large allocations on Nightly. The allocation sizes are around 1GB. It looks like these first showed up in the 4/27 build. Maybe this is a regression from bug 1266623?
Flags: needinfo?(kinetik)
Keywords: crash, regression
Andrew, are you seeing these locally or is this just from crash reports? Looking for a way to repro and/or more information about the audio config. Those allocation sizes might suggest an underflow but I'm not seeing a way for that to happen. The linear_buffer should be pretty small in general and we assert that we empty it during every callback cycle, so I don't think it's a case where it's growing without bound and eventually hitting an overflow/huge alloc directly. ccing Paul in case he has ideas.
Flags: needinfo?(kinetik)
Do we have stacks, or ways to repro for this, or any other info ?
Flags: needinfo?(continuation)
(In reply to Paul Adenot (:padenot) from comment #2) > Do we have stacks, or ways to repro for this, or any other info ? I filed this based on crash-stats. If you click on the link in "Crash Signature" it will take you to the crash reports. Unfortunately none of the reports have a URL or user comment so I don't have any more information about how to reproduce.
Flags: needinfo?(continuation)
Keywords: steps-wanted
Assignee: nobody → padenot
Rank: 10
Priority: -- → P1
This was likely fixed in bug 1270062. There aren't any crashes in 49 with this signature after 05/03.
Fixed based on bug 1270062 and crash-stats.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
i'm reopening this bug since the signature is on the rise in 50.0b builds again, the allocation sizes are smaller now though like in https://crash-stats.mozilla.com/report/index/43269eab-085c-4037-b95e-4b4602161014
Status: RESOLVED → REOPENED
Flags: needinfo?(kinetik)
Resolution: FIXED → ---
I think this is because of this `ceilf` [0]. We're rounding the size of the buffer up each time, and it accumulates, and then crashes. [0]: https://hg.mozilla.org/releases/mozilla-release/annotate/2d931a5eaf8a/media/libcubeb/src/cubeb_resampler_internal.h#l266
Depends on: 1310206
The cause and fix are different, I'm opening a new bug for this.
I agree, a new bug is appropriate.
Status: REOPENED → RESOLVED
Closed: 9 years ago8 years ago
Resolution: --- → FIXED
Flags: needinfo?(kinetik)
We really want to be tracking Bug 1310206, which I just nominated for tracking-firefox50 -- which fixes bug 1310224. This was reopened under the assumption that bug 1310224 was this bug, and they are different.
You need to log in before you can comment on or make changes to this bug.