Closed Bug 1268738 Opened 8 years ago Closed 8 years ago

Firebug theme - Do not display light-theme breadcrumbs-divider in the Firebug theme

Categories

(DevTools :: Inspector, defect, P2)

defect

Tracking

(firefox48 wontfix, firefox49 wontfix, firefox50 verified)

RESOLVED FIXED
Firefox 50
Tracking Status
firefox48 --- wontfix
firefox49 --- wontfix
firefox50 --- verified

People

(Reporter: magicp.jp, Assigned: Kwan)

References

Details

(Whiteboard: [btpp-fix-later])

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160428030218

Steps to reproduce:

1. Start Nightly
2. Go to any sites (e.g. about:home)
3. Open DevTools > Inspector with Firebug theme
4. Confirm breadcrumbs-divider


Actual results:

The light theme breadcrumbs-divider is displayed in the Firebug theme. Please find attached image.


Expected results:

Do not display light-theme breadcrumbs-divider in the Firebug theme.
Has STR: --- → yes
Component: Untriaged → Developer Tools: Inspector
OS: Unspecified → All
Hardware: Unspecified → All
Bug triage (filter on CLIMBING SHOES).
Priority: -- → P2
Whiteboard: [btpp-fix-later]
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Resolution: FIXED → WORKSFORME
I'm still seeing this, patch incoming.
Assignee: nobody → moz-ian
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Prevents two breadcrumb arrows from appearing because the light-theme breadcrumb
is a background while the firebug-theme one is a CSS generated element

Review commit: https://reviewboard.mozilla.org/r/61960/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/61960/
Attachment #8767486 - Flags: review?(ntim.bugs)
Comment on attachment 8767486 [details]
Bug 1268738 - Remove the background image from devtools breadcrumbs in the firebug theme.

https://reviewboard.mozilla.org/r/61960/#review58702

So this reproduces with 3 or more items, not with 2 items. Thanks for fixing this!
Attachment #8767486 - Flags: review?(ntim.bugs) → review+
Thanks again for the speedy review Tim!

Sheriff, as with bug 1205569 I feel the triviality of this change renders a try run a waste of resources, but again let me know if you disagree.
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/c8a3e468c15d
Remove the background image from devtools breadcrumbs in the firebug theme. r=ntim
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c8a3e468c15d
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
I have reproduced this bug with Nightly 49.0a1 (2016-04-28) on Windows 7 , 64 Bit !

This bug's fix is verified with latest Developer Edition (Aurora)

Build ID   20160907004009
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0

[bugday-20160907]
Hello Maruf, Thanks!
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: