Closed Bug 1268887 Opened 9 years ago Closed 4 years ago

Incorrect home panel restored from history if initially loaded using direct panel URL

Categories

(Firefox for Android Graveyard :: Awesomescreen, defect)

defect
Not set
normal

Tracking

(firefox49 affected)

RESOLVED INCOMPLETE
Tracking Status
firefox49 --- affected

People

(Reporter: ahunt, Unassigned)

References

Details

Attachments

(1 file)

1. Navigate directly to a specific homepanel, e.g. bookmark a reader-view page, select SWITCH, we open directly to the bookmarks panel. 2. swipe to another panel, e.g. topsites 3. open a page, i.e. select a topsite 4. press back Expected: we return to the topsites panel Actual: we return to the bookmarks panel This should be a simple fix, we're trying to be too clever when restoring homepanels, but ultimately the URL is useless when restoring about:home from history since we never update the URL when switching between homepanels. (We could instead fix/update the URL, but that seems expensive from an engineering perspective.)
Blocking on bug 1060544 since that's also modifying our restore logic.
Assignee: nobody → ahunt
Status: NEW → ASSIGNED
Depends on: 1060544
On further thought, this might be unfixable: We call updateHomePagerForTab on LOCATION_CHANGE, but we don't know if this LOCATION_CHANGE is the result of going back in history, or navigating directly to a panel. We'd have to figure this out, or completely strip panelIds from about:home when writing that to history. I'll push a patch to review which tries to always restore the panel, but it's pretty much useless given the above comments.
Unassigning myself since I'm not actively looking into this. Fixing this properly would probably involve substantial work around storing the actual panels (and restore data) in history, and this probably isn't a priority right now.
Assignee: ahunt → nobody
Status: ASSIGNED → NEW
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: