Closed
Bug 1268982
Opened 9 years ago
Closed 8 years ago
Generate a single unified rust library under LINK_GTEST
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox49 affected)
RESOLVED
WORKSFORME
Tracking | Status | |
---|---|---|
firefox49 | --- | affected |
People
(Reporter: rillian, Unassigned)
References
Details
We link rust code into gecko by generating a unified crate which references every crate we want to include. This is compiled to a staticlib from the unified source and rlib files built from all the individual crate sources.
Unfortunately we're doing this once for libxul and again for the gtest library, and linking both into the gtest-specific libxul, so we still end up with duplicate copies of library symbols.
We should merge the XUL-targeted crate list into toolkit/library/gtest/rul.rs and link only one of the two librul.a builds into libxul.so.
Comment 1•8 years ago
|
||
I think this is taken care of by using cargo to build things in bug 1231764.
Reporter | ||
Comment 2•8 years ago
|
||
Great.
Comment 3•8 years ago
|
||
Is this fixed then?
Comment 4•8 years ago
|
||
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> Is this fixed then?
Yes.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•