Closed Bug 1269067 Opened 8 years ago Closed 8 years ago

[APZ] Text selection interferes with scrolling with mouse wheel

Categories

(Core :: Panning and Zooming, defect, P2)

48 Branch
defect

Tracking

()

VERIFIED FIXED
mozilla51
Tracking Status
firefox46 --- unaffected
firefox47 --- unaffected
firefox48 --- wontfix
firefox49 --- wontfix
firefox50 --- wontfix
firefox51 --- verified

People

(Reporter: arni2033, Assigned: kats)

References

Details

(Keywords: correctness, regression, Whiteboard: [gfx-noted])

Attachments

(1 file)

>>>   My Info:   Win7_64, Nightly 49, 32bit, ID 20160429030215
STR_1:
1. Open https://www.mozilla.org/en-US/firefox/nightly/firstrun/ or bug 1257491
2. Start selecting text (don't perform 'mouseup'), and keep slightly moving mouse to the left/right
3. Rotate mouse wheel down to scroll the page


STR_2:
0. (unnecessary) Set mouse option "when I rotate mouse wheel" in OS to "scroll by 40 lines",
   open about:config and set pref "general.smoothScroll.mouseWheel.durationMaxMS" to "4000"
1. Open https://www.mozilla.org/en-US/firefox/nightly/firstrun/ or bug 1257491
2. Start selecting text (don't perform 'mouseup')
3. Rotate mouse wheel down to scroll the page
4. Move mouse to the left/right while the page is still scrolling


AR:  STR_1 - scroll doesn't happen. STR_2 - scroll is stopped.
ER:  STR_1 - scroll should happen.  STR_2 - scroll should continue.

I first detected STR_1, but found regression range using STR_2. That was a really smooooth testing.

This is regression from bug 1242690. Regression range:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=0c1e74f83b4187dc5563b2fc4a64f19065132700&tochange=1d931aacb06118b0c182fea0d6d3d529b380cdb6
For me, with STR_1, the scroll still happens, but it doesn't get as far, as if the continued selection interrupts the wheel scroll animation.
Blocks: apz-desktop
Keywords: correctness
Whiteboard: [gfx-noted]
Confirmed that backing out bug 1242690 locally fixes the problem. Marking 48 as affected and 47 and below as unaffected on that basis.
Version: unspecified → 48 Branch
Priority: -- → P2
Attached patch Gtest (deleted) — Splinter Review
The patches on bug 1289432 fix this bug; here is a gtest to ensure it stays fixed.
Attachment #8790535 - Flags: review?(botond)
Attachment #8790535 - Flags: review?(botond) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/879cf2af8ca9
Add a gtest to ensure that mouse drag blocks and wheel blocks don't interrupt each other. r=botond
https://hg.mozilla.org/mozilla-central/rev/879cf2af8ca9
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Verified as fixed under Win 10 64-bit using Nightly 51.0a1 2016-09-18.

I could also reproduce and verify under Mac OS X 10.11.6 and Ubuntu 16.04 64-bit, after setting a bigger value for mousewheel.default.delta_multiplier_y.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: