Closed Bug 1269738 Opened 9 years ago Closed 9 years ago

Lock nsHttpRequestHead::SetHeader

Categories

(Core :: Networking: HTTP, defect)

Product:
Core
Component:
Networking: HTTP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: dragana, Assigned: dragana)

References

Details

(Whiteboard: [necko-active])

Attachments

(1 file)

bug_lockSetHeader.patch
(deleted), patch
mcmanus
: review+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review 
I forgot to lock SetHeader :)
Assignee: nobody → dd.mozilla
Blocks: 1247982
Status: NEW → ASSIGNED
Whiteboard: [necko-active]
Attached patch bug_lockSetHeader.patch (deleted) — — Splinter Review 

  

  



        Attachment #8748154 -
        Flags: review?(mcmanus)

    
    

    
  
https://treeherder.mozilla.org/#/jobs?repo=try&revision=618d18461abc

  

  



        Attachment #8748154 -
        Flags: review?(mcmanus) → review+

    
  
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d557a4bf9ac

  

  


Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/7d557a4bf9ac

  

  


Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox49:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49

    
    

    
  
Comment on attachment 8748154 [details] [diff] [review]
bug_lockSetHeader.patch

Approval Request Comment
[Feature/regressing bug #]: Needed for uplift of bug 1247982
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: No risk it is one line patch
[String/UUID change made/needed]:



Order of uplift:
bug 1247982,
this patch,
bug 1274509

  

  



        Attachment #8748154 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 8748154 [details] [diff] [review]
bug_lockSetHeader.patch

This is for 48 beta

  

  



        Attachment #8748154 -
        Flags: approval-mozilla-aurora? → approval-mozilla-beta?

    
    

    
  
Comment on attachment 8748154 [details] [diff] [review]
bug_lockSetHeader.patch

Review of attachment 8748154 [details] [diff] [review]:
-----------------------------------------------------------------

This patch fixed lock for SetHeader. Take it in 48 beta 3.

  

  



        Attachment #8748154 -
        Flags: approval-mozilla-beta? → approval-mozilla-beta+

    
    

    
  
Comment on attachment 8748154 [details] [diff] [review]
bug_lockSetHeader.patch

Review of attachment 8748154 [details] [diff] [review]:
-----------------------------------------------------------------

Need to take a close look at 3 bugs.

  

  



        Attachment #8748154 -
        Flags: approval-mozilla-beta+ → approval-mozilla-beta?

    
    

    
  
Comment on attachment 8748154 [details] [diff] [review]
bug_lockSetHeader.patch

Take it for the bug 1247982
Should be in 48 beta 3

  

  



        Attachment #8748154 -
        Flags: approval-mozilla-beta? → approval-mozilla-beta+

    
    

    
  
https://hg.mozilla.org/releases/mozilla-beta/rev/b142c2e3bf73

  

  



          status-firefox48:
          affected → fixed

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: