Closed Bug 1269976 Opened 9 years ago Closed 8 years ago

Make nsCSSPseudoElements::GetPseudoType accept an EnabledState

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(2 files)

MozReview Request: Bug 1269976 part 1 - Move CSSPseudoElements_flags to a static array in nsCSSPseudoElements. r=heycam
(deleted), text/x-review-board-request
heycam
: review+
Details
MozReview Request: Bug 1269976 part 2 - Add nsCSSPseudoElements::IsEnabled() and make GetPseudoType take CSSEnabledState. r?heycam
(deleted), text/x-review-board-request
heycam
: review+
Details
We may want to allow conditionally enable pseudo elements as well, like pseudo classes and properties.
Summary: Make nsCSSPeudoElements::GetPseudoType accepts a EnabledState → Make nsCSSPseudoElements::GetPseudoType accept an EnabledState
Assignee: nobody → bugzilla
Comment on attachment 8749006 [details] MozReview Request: Bug 1269976 part 1 - Move CSSPseudoElements_flags to a static array in nsCSSPseudoElements. r=heycam https://reviewboard.mozilla.org/r/50679/#review47995
Attachment #8749006 - Flags: review?(cam) → review+
Comment on attachment 8749007 [details] MozReview Request: Bug 1269976 part 2 - Add nsCSSPseudoElements::IsEnabled() and make GetPseudoType take CSSEnabledState. r?heycam https://reviewboard.mozilla.org/r/50681/#review47997 Looks good, one question. ::: layout/inspector/inDOMUtils.cpp:1236 (Diff revision 1) > > const CSSPseudoElementTypeBase pseudoCount = > static_cast<CSSPseudoElementTypeBase>(CSSPseudoElementType::Count); > for (CSSPseudoElementTypeBase i = 0; i < pseudoCount; ++i) { > CSSPseudoElementType type = static_cast<CSSPseudoElementType>(i); > - if (!nsCSSPseudoElements::PseudoElementIsUASheetOnly(type)) { > + if (!nsCSSPseudoElements::IsEnabled(type, CSSEnabledState::eAllContent)) { Should the "!" be removed?
Attachment #8749007 - Flags: review?(cam)
https://reviewboard.mozilla.org/r/50681/#review47997 > Should the "!" be removed? Oops... yeah, it should. Thanks for catching that.
Comment on attachment 8749006 [details] MozReview Request: Bug 1269976 part 1 - Move CSSPseudoElements_flags to a static array in nsCSSPseudoElements. r=heycam Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50679/diff/1-2/
Attachment #8749006 - Attachment description: MozReview Request: Bug 1269976 part 1 - Move CSSPseudoElements_flags to a static array in nsCSSPseudoElements. r?heycam → MozReview Request: Bug 1269976 part 1 - Move CSSPseudoElements_flags to a static array in nsCSSPseudoElements. r=heycam
Attachment #8749007 - Flags: review?(cam)
Comment on attachment 8749007 [details] MozReview Request: Bug 1269976 part 2 - Add nsCSSPseudoElements::IsEnabled() and make GetPseudoType take CSSEnabledState. r?heycam Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50681/diff/1-2/
Attachment #8749007 - Flags: review?(cam) → review+
Comment on attachment 8749007 [details] MozReview Request: Bug 1269976 part 2 - Add nsCSSPseudoElements::IsEnabled() and make GetPseudoType take CSSEnabledState. r?heycam https://reviewboard.mozilla.org/r/50681/#review48001
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f7ecae8e6637fb8208c28f522d5dd43f342cb9d Bug 1269976 part 1 - Move CSSPseudoElements_flags to a static array in nsCSSPseudoElements. r=heycam https://hg.mozilla.org/integration/mozilla-inbound/rev/4e949692600a455c44616fc97cea2d17a546681a Bug 1269976 part 2 - Add nsCSSPseudoElements::IsEnabled() and make GetPseudoType take CSSEnabledState. r=heycam
https://hg.mozilla.org/integration/mozilla-inbound/rev/03a6279bb233dbf539d8ff4614f6309b90f3ca43 Bug 1269976 part 1 - Move CSSPseudoElements_flags to a static array in nsCSSPseudoElements. r=heycam https://hg.mozilla.org/integration/mozilla-inbound/rev/8f803cb0eac1fc590a3f9f35fc6a593e6e2d022a Bug 1269976 part 2 - Add nsCSSPseudoElements::IsEnabled() and make GetPseudoType take CSSEnabledState. r=heycam
https://hg.mozilla.org/mozilla-central/rev/03a6279bb233 https://hg.mozilla.org/mozilla-central/rev/8f803cb0eac1
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Depends on: 1273048
Depends on: 1314531
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: