Closed Bug 1270139 Opened 8 years ago Closed 8 years ago

remove last use of domutils.colorToRGBA

Categories

(DevTools :: Framework, defect, P1)

Product:
DevTools
Component:
Framework
Type:
defect

Tracking

(firefox49 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 49
Iteration:
49.1 - May 9
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: tromey, Assigned: tromey)

References

Details

(Whiteboard: [devtools-html])

Attachments

(1 file)

MozReview Request: Bug 1270139 - don't use inIDOMUtils.colorToRGBA in devtools; r=pbro
(deleted), text/x-review-board-request
pbro
: review+
Details 
The patch for bug 1266842 missed one use of domutils.colorToRGBA.
Flags: qe-verify-
Whiteboard: [devtools-html] → [devtools-html] [triage]
Iteration: --- → 49.1 - May 9
Priority: -- → P1
Whiteboard: [devtools-html] [triage] → [devtools-html]
Bug 1266842 missed a spot using colorToRGBA.  Changing this revealed
that the hsltorgb algorithm was a bit off; so this patch changes it to
be a js port of NS_HSL2RGB.

Review commit: https://reviewboard.mozilla.org/r/50493/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50493/
Attachment #8748711 - Flags: review?(pbrosset)
Attachment #8748711 - Flags: review?(pbrosset) → review+
Comment on attachment 8748711 [details]
MozReview Request: Bug 1270139 - don't use inIDOMUtils.colorToRGBA in devtools; r=pbro

https://reviewboard.mozilla.org/r/50493/#review47701
Since bug 1265787, this was the last use of domutils in css-color.js.
So, I'm going to attach a small update that removes the import.
Comment on attachment 8748711 [details]
MozReview Request: Bug 1270139 - don't use inIDOMUtils.colorToRGBA in devtools; r=pbro

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50493/diff/1-2/
Attachment #8748711 - Attachment description: MozReview Request: Bug 1270139 - don't use inIDOMUtils.colorToRGBA in devtools; r?pbro → MozReview Request: Bug 1270139 - don't use inIDOMUtils.colorToRGBA in devtools; r=pbro
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e818d8cb31a9
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: